Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.I configured the creation-plugin so that it deletes revisions older than 2 years.
I have a node for which the revision overview shows revisions older than 2 years.
But these revisions are never deleted.
I digged in a little but and it looks like the revision changed time is assumed as the revision creation time:
// The timestamp of the created revision is stored in the changed field.
$creation_time = $revision->getChangedTime();
This is incorrect. A past revision can be changed.
The appropriate way to get a revision's creation time is the getRevisionCreationTime() method. This method gets the timestamp stored under the revision_timestamp key (which is the same value that is used in the node revision overview).
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | node_revision_delete-revision_creation_time-3447094-7.patch | 4.08 KB | rp7 |
Issue fork node_revision_delete-3447094
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3447094-creation-time
changes, plain diff MR !46 - 3447094-the-creation-time changes, plain diff MR !45
Comments
Comment #2
rp7 commentedComment #3
rp7 commentedComment #5
rp7 commentedUpdating tests.
Comment #6
rp7 commentedUpdating tests.
Comment #7
rp7 commentedUpdating tests. Expecting them to succeed now.
Comment #8
rp7 commentedComment #9
berdir> This is incorrect. A past revision can be changed.
Why should a revision get deleted if it has been updated?
Comment #10
rp7 commentedNot sure if that even matters? The plugin is falsely claiming to base a deletion based on the revision creation time, but in fact it's using the changed time (while there's a creation time available).
FWIW, we have a project where we update old revisions retro-actively, when - for example - we add a new (required) fields to the content type.
Comment #11
rob230 commentedWe have this problem as well. I don't know what caused revisions to have a different updated date than created date, but it makes this module appear to not do what it claims, because in the backend the revisions are listed with the created date being X time ago, but they don't get deleted.
getRevisionCreationTime()is surely the correct method to use here.Comment #12
rob230 commentedComment #13
alexpottI think that the issue summary details the problem quite well. If are telling the user we are going to delete revisions created older than 2 years and then don't that's a bug.
It feels like we should add a new plugin that uses the updated time and update existing sites to use that and have a created plugin that works as expected. That way sites can choose what they want to do.
Comment #17
eduardo morales albertiCreated MR updated with 2.0.x branch
Comment #20
lamp5I rebased the MR. I see that similar issue has been commited. I need to test the latest version of the module.