Problem/Motivation

If use Field (html DivIcon) option in the Map Icon and provide a token value, for example, an image field from the node
When the image field is empty map will render the text of the provided token, for example: ([node:field_image:entity:thumbnail])
This is wrong behavior, because if the token is empty marker html markup needs to be used

This bug exists only on the node view form, for views it works well

Issue fork leaflet-3447061

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

rollins created an issue. See original summary.

rollins opened merge request !38

rollins’s picture

rollins commented
Status: Needs work » Needs review

Just provided MR that will fix this bug

nginex’s picture

nginex commented
Assigned: Unassigned » nginex
nginex’s picture

nginex commented
Assigned: nginex » Unassigned
Priority: Major » Normal
Status: Needs review » Reviewed & tested by the community

It works like a charm

itamair’s picture

itamair commented
Status: Reviewed & tested by the community » Needs review

Thanks for this ... but I also want to properly QA and Review this.
Not clear to me if this fix is needed only in the Leaflet Formatter,
or something needs to be adjusted / fixed in the Leaflet View Style too
(usually they pair each other ... ).

  • itamair committed 11568266 on 10.2.x authored by rollins 
    Issue #3447061 by rollins, nginex: Token in map icon field does not work...
itamair’s picture

itamair commented
Status: Needs review » Fixed

Thanks again ... merging this.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.