Problem/Motivation

Adding the GitLab CI template finds many coding standards issues. Let's fix those.

Issue fork rename_admin_paths-3444739

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

ptmkenny created an issue. See original summary.

ptmkenny opened merge request !14

ptmkenny’s picture

ptmkenny commented
Status: Active » Needs review
rollins’s picture

rollins commented
Status: Needs review » Reviewed & tested by the community

Changes from MR look great!
I think we need to merge this

ptmkenny’s picture

ptmkenny commented
Status: Reviewed & tested by the community » Needs work

@rollins What kind of testing did you do?

Looking at this again, PHPStorm identifies a few issues with this MR: @inheritDoc used for member without parent members with doc comments. These need to be fixed before committing.

ptmkenny’s picture

ptmkenny commented
Status: Needs work » Needs review
ptmkenny’s picture

ptmkenny commented

  • ptmkenny committed 696feddd on 8.x-2.x 
    Issue #3444739 by ptmkenny: Fix coding standards issues
ptmkenny’s picture

ptmkenny commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.