After upgrading my Drupal installation to 10.1.x CSS/JS aggregation no longer seemed to work. After some research it appears Anonymous Redirect is instructing a redirect for the sites/default/files/js/* and sites/default/files/css/* paths.

Unsure, but might be related to the changes in #2888767: Asset aggregation deprecations and additions, hook_js_alter()/hook_css_alter() changes?

CommentFileSizeAuthor
#5 anonmyous_redirect-assets_no_redirect-3444326-5.patch6.16 KBrp7
#3 anonmyous_redirect-assets_no_redirect-3444326-4.patch4.05 KBrp7

Issue fork anonymous_redirect-3444326

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

rp7 created an issue. See original summary.

rp7 opened merge request !9

rp7’s picture

rp7 commented
Assigned: rp7 » Unassigned
Status: Active » Needs review
StatusFileSize
new anonmyous_redirect-assets_no_redirect-3444326-4.patch4.05 KB

MR opened + patch attached.

mstrelan’s picture

mstrelan commented
Status: Needs review » Needs work

Left some nits and a question about compatibility. Test coverage would be good if possible.

rp7’s picture

rp7 commented
StatusFileSize
new anonmyous_redirect-assets_no_redirect-3444326-5.patch6.16 KB

Made a few proposed changes + tried to get the tests green.
A test for an actual asset generation path should still be added, though.

mstrelan’s picture

mstrelan commented

Needs a rebase

mstrelan’s picture

mstrelan commented
Status: Needs work » Needs review

Rebased and started looking at test coverage, but one glaring issue is that the asset generation directory by default is the same as the public file system. This might be ok though, since it's usually served directly by apache anyway, except for the image styles directory.

fmb’s picture

fmb commented
Status: Needs review » Reviewed & tested by the community

We have been using this fix for a few months, and it works well.

jimmynash’s picture

jimmynash commented

This fix has been working for us as well.

  • mstrelan committed 6981e119 on 8.x-2.x authored by rp7 
    fix: #3444326 Don't redirect on asset generation paths

By: rp7
By:...
mstrelan’s picture

mstrelan commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.