Closed (fixed)
Project:
Project Browser
Version:
1.0.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
27 Apr 2024 at 22:59 UTC
Updated:
15 May 2024 at 14:59 UTC
Jump to comment: Most recent
Fixes issue #3310884: Ability to clear keyword/search filter with one click seems to have introduced some new PHPCS issues:
FILE: ...ct_browser-3443929/tests/src/FunctionalJavascript/ProjectBrowserUiTest.php
--------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------------
980 | ERROR | [x] Visibility must be declared on method
| | "testClearKeywordSearch" (Drupal.Scope.MethodScope.Missing)
985 | ERROR | [x] Whitespace found at end of line
| | (Squiz.WhiteSpace.SuperfluousWhitespace.EndLine)
1000 | ERROR | [x] Whitespace found at end of line
| | (Squiz.WhiteSpace.SuperfluousWhitespace.EndLine)
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...oject_browser-3443929/src/Plugin/ProjectBrowserSource/MockDrupalDotOrg.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
89 | ERROR | [x] Multi-line function declaration not indented correctly;
| | expected 2 spaces but found 3
| | (Drupal.Functions.MultiLineFunctionDeclaration.Indent)
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...browser-3443929/src/EventSubscriber/DisableAddNewModuleRouteSubscriber.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
21 | ERROR | [x] Multi-line function declarations must have a trailing comma
| | after the last parameter
| | (Drupal.Functions.MultiLineFunctionDeclaration.MissingTrailingComma)
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLYSee pipeline output: https://git.drupalcode.org/issue/project_browser-3443929/-/jobs/1453514
Correct PHPCS errors.
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
lostcarpark commentedResolved PHPCS errors.
Comment #4
bernardm28 commentedLooks good, thanks for checking and fixing those.
Comment #7
chrisfromredfinThanks!