Problem/Motivation

Fixes issue #3310884: Ability to clear keyword/search filter with one click seems to have introduced some new PHPCS issues:

FILE: ...ct_browser-3443929/tests/src/FunctionalJavascript/ProjectBrowserUiTest.php
--------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------------
  980 | ERROR | [x] Visibility must be declared on method
      |       |     "testClearKeywordSearch" (Drupal.Scope.MethodScope.Missing)
  985 | ERROR | [x] Whitespace found at end of line
      |       |     (Squiz.WhiteSpace.SuperfluousWhitespace.EndLine)
 1000 | ERROR | [x] Whitespace found at end of line
      |       |     (Squiz.WhiteSpace.SuperfluousWhitespace.EndLine)
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...oject_browser-3443929/src/Plugin/ProjectBrowserSource/MockDrupalDotOrg.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 89 | ERROR | [x] Multi-line function declaration not indented correctly;
    |       |     expected 2 spaces but found 3
    |       |     (Drupal.Functions.MultiLineFunctionDeclaration.Indent)
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...browser-3443929/src/EventSubscriber/DisableAddNewModuleRouteSubscriber.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 21 | ERROR | [x] Multi-line function declarations must have a trailing comma
    |       |     after the last parameter
    |       |     (Drupal.Functions.MultiLineFunctionDeclaration.MissingTrailingComma)
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY

Steps to reproduce

See pipeline output: https://git.drupalcode.org/issue/project_browser-3443929/-/jobs/1453514

Proposed resolution

Correct PHPCS errors.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

lostcarpark created an issue. See original summary.

lostcarpark’s picture

Status: Active » Needs review

Resolved PHPCS errors.

bernardm28’s picture

Status: Needs review » Reviewed & tested by the community

Looks good, thanks for checking and fixing those.

chrisfromredfin made their first commit to this issue’s fork.

chrisfromredfin’s picture

Status: Reviewed & tested by the community » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.