Closed (fixed)
Project:
Drupal core
Version:
11.x-dev
Component:
other
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
26 Apr 2024 at 21:09 UTC
Updated:
17 May 2024 at 13:19 UTC
Jump to comment: Most recent
#3438895: Add the new Navigation to core as an Experimental module added Navigation as alpha experimental. Decide on whether Navigation is ready to marked as beta experimental.
The Navigation roadmap with all the major issues found can be found at #3421969: [PLAN] New Navigation and Top Bar to replace Toolbar Roadmap: Path to Stable.
Comments
Comment #2
lauriiiComment #3
ckrinaComment #4
mherchelYay! We're in core! Now let's get in 10.3.0!
So, I don't see any beta blockers listed in #3421969: [PLAN] New Navigation and Top Bar to replace Toolbar Roadmap: Path to Stable. Is this the only blocker? If so, can you elaborate or should we go though again?
What actionable steps are needed to get this into 10.3.0?
Comment #5
larowlanFrom a Framework manager POV I'm happy to mark navigation as beta level stability, there's no changes outside the module, all the code is final and internal and the data model reuses the existing layout builder schema
Comment #6
catchI've reviewed both the initial MR (a bit) and the roadmap issue/sub-issues (a fair bit), and I think @longwave has also reviewed the roadmap. There is a fair bit to do but it's all beta-safe, and we're already seeing more testing after the commit, so happy removing the RM tag here.
Comment #8
xjmI also have no objections to it being marked beta. (Don't credit me though; did not put time into reviewing it myself).
Comment #9
xjmAside: This is the issue to tag for both release notes and release highlights, if/when the FEFM signoff is given.
Comment #10
bnjmnmGoing through the JS it all looks fine for the Navigation module but I'm a little unsure about it becoming an API available to other extensions. Instead of dealing with the buzzkill of last minute JS change requests, we can address my concerns about this being marked beta experimental by just making the libraries internal #3444932: Make libraries with JS internal, at least for beta
Comment #11
nod_Same here, the JS is ok with me for a Beta, for stable i want to use proper events like we did for dialog but that can wait (since we'll be marking all the JS apis internal for now), there is generally too much nesting, some things can be refactored but nothing impacting the user experience, it's mostly about DX and maintenance. Better get this feature in users' hands first.
Comment #12
lauriiiLooks like we have sign-offs from all roles and #3444932: Make libraries with JS internal, at least for beta has been committed.
Comment #13
quietone commentedAdding tag per #9