Problem/Motivation

The message with expiration date in ChangePasswordResetForm::buildForm() contains a new line.

<p>This is a one-time login for %user_name and will expire on 
%expiration_date.</p><p>Click on this button to log in to the site and change your password.</p>

The same message in UserPasswordResetForm::buildForm() does not contain a new line.

It leads to missing translation in other languages https://ftp.drupal.org/files/translations/all/change_pwd_page/

Proposed resolution

Remove the new line \n in ChangePasswordResetForm class.

CommentFileSizeAuthor
#2 change_pwd_page-3443755.patch1.03 KBamaloisel

Issue fork change_pwd_page-3443755

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

tbwetix created an issue. See original summary.

amaloisel’s picture

amaloisel commented
StatusFileSize
new change_pwd_page-3443755.patch1.03 KB

Hello,

I have same issue, here a patch to fix it.

amaloisel’s picture

amaloisel commented
dhruv.mittal’s picture

dhruv.mittal commented
Assigned: Unassigned » dhruv.mittal

dhruv.mittal opened merge request !19

dhruv.mittal’s picture

dhruv.mittal commented
Assigned: dhruv.mittal » Unassigned
Status: Active » Needs review

As Patch is deprecated so I've raised MR for the given patch. Kindly review

shivam_tiwari’s picture

shivam_tiwari commented
Status: Needs review » Reviewed & tested by the community

I checked the MR and applied it as a patch. Patch is applied successfully without any error, and it resolves issue as mentioned in description.
Moving this to RTBC

  • dhruv.mittal committed 6b0d83e1 on 8.x-1.x 
    Issue #3443755: Remove new line from ChangePasswordResetForm message.
adriancid’s picture

adriancid
Primary language Spanish
Location Qc, Canada 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.