Problem/Motivation

Recently with Drupal 10.3 a new starterkit.yml file has been introduced as mentioned here. The generate-theme command will now look for a theme_name.starterkit.yml file within the theme's root, this replaces the starterkit: true within the theme’s info.yml file.

The theme generator command will loop through all files and filenames and do a string replace of the machine_name of the starterkit theme with the machine_name of the new theme which may mean we can reduce some of the work being leveraged by our custom generator.

Proposed resolution

Create starterkit.yml file and remove key in info.yml file
Review and test generator for new options provided by the yml file.

Issue fork prototype-3443348

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

jldust created an issue. See original summary.

jldust’s picture

Status: Active » Needs review

pixelwhip made their first commit to this issue’s fork.

pixelwhip’s picture

Status: Needs review » Reviewed & tested by the community

Thanks for working on this @jldust. For some reason the /tests folder wasn't getting removed despite it being in the ignore list. I added a work around for that. For some reason the Cypress tests that test the generated theme aren't passing on Tugboat despite them passing locally. Manually testing the changes works. There are some commits I've added that help address the issue but it still isn't fully passing. I don't want to hold this change up any longer though so I'm going to pause here. I think this is good to go otherwise.

b-ry’s picture

@jdust I tested this and it looks good to me. Works great!

  • jldust committed 30247f1c on 5.x
    Issue #3443348 by pixelwhip, jldust, b-ry: Update to new starterkit.yml...
jldust’s picture

Status: Reviewed & tested by the community » Fixed

Thanks for testing this, I agree about merging this in and creating another ticket to resolve the Cypress testing issues.

jldust’s picture

Status: Fixed » Closed (fixed)