[1.0.x] Quiz Maker

Thank you for applying!

Please read Review process for security advisory coverage: What to expect for more details and Security advisory coverage application checklist to understand what reviewers look for. Tips for ensuring a smooth review gives some hints for a smoother review.

The important notes are the following.

• If you have not done it yet, you should run phpcs --standard=Drupal,DrupalPractice on the project, which alone fixes most of what reviewers would report.
• For the time this application is open, only your commits are allowed.
• The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
• We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.

To the reviewers

Please read How to review security advisory coverage applications, Application workflow, What to cover in an application review, and Tools to use for reviews.

The important notes are the following.

• It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
• Reviewers should show the output of a CLI tool only once per application.
• It may be best to have the applicant fix things before further review.

For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues.

1. master is a wrong name for a branch. Release branch names always end with the literal .x as described in Release branches.

2. Fix phpcs issues.

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml quiz_maker/

FILE: quiz_maker/src/Plugin/QuizMaker/QuestionPluginBase.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 203 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
--------------------------------------------------------------------------------

FILE: quiz_maker/src/Plugin/QuizMaker/Answer/DirectAnswer.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 27 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
--------------------------------------------------------------------------------

FILE: quiz_maker/src/Plugin/QuizMaker/Question/DirectQuestion.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 65 | WARNING | Unused variable $res.
--------------------------------------------------------------------------------

FILE: quiz_maker/src/Plugin/QuizMaker/QuestionResponsePluginBase.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 79 | WARNING | Exceptions should not be translated
--------------------------------------------------------------------------------

FILE: quiz_maker/src/Entity/Quiz.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
--------------------------------------------------------------------------------
 534 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 539 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 547 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 551 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
--------------------------------------------------------------------------------

FILE: quiz_maker/src/Entity/QuizResult.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 193 | ERROR | The array declaration extends to column 97 (the limit is 80). The array content should be split up over multiple lines
--------------------------------------------------------------------------------

FILE: quiz_maker/css/quiz_timer.css
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 56 | ERROR | [x] Expected 1 space before opening brace of class definition; 2 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: quiz_maker/css/quiz_maker.css
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 251 | ERROR | [x] Blank lines are not allowed in class definitions
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

3. FILE: quiz_maker.module

/**
 * @file
 * Primary module hooks for Quiz Maker module.
 */

In Drupal, there are no primary and secondary hooks. The usual description for a .module file is Hook implementations for the [module name] module. where [module name] is the module name given in the .info.yml file.

4. FILE: src/Controller/QuizMakerController.php

  /**
   * The controller constructor.
   */
  public function __construct(

FILE: src/Event/QuizTakeEvent.php

  /**
   * Class constructor.
   *
   * @param \Drupal\quiz_maker\QuizInterface $quiz
   *   The quiz.
   * @param \Drupal\quiz_maker\QuizResultInterface $quizResult
   *   The quiz result.
   */
  public function __construct(

FILE: src/Event/ResponseEvent.php

  /**
   * Class constructor.
   *
   * @param \Drupal\quiz_maker\QuizResultInterface $quizResult
   *   The quiz result.
   * @param \Drupal\quiz_maker\QuestionResponseInterface $questionResponse
   *   The question user's response.
   */
  public function __construct(

FILE: src/Event/QuestionNavigationEvent.php

  /**
   * Class constructor.
   *
   * @param \Drupal\quiz_maker\QuizInterface $quiz
   *   The quiz.
   * @param \Drupal\quiz_maker\QuestionInterface $currentQuestion
   *   The current question.
   * @param \Drupal\Core\Session\AccountInterface $user
   *   The user.
   * @param int $nextQuestionNumber
   *   The next question number.
   */
  public function __construct(

FILE: src/Service/QuizMakerQuestionAnswerPluginManager.php

  /**
   * Constructs the object.
   */
  public function __construct(\Traversable $namespaces, CacheBackendInterface $cache_backend, ModuleHandlerInterface $module_handler) {

FILE: src/Service/QuizMakerQuestionPluginManager.php

  /**
   * Constructs the object.
   */
  public function __construct(\Traversable $namespaces, CacheBackendInterface $cache_backend, ModuleHandlerInterface $module_handler) {

FILE: src/Service/QuizMakerQuestionResponsePluginManager.php

  /**
   * Constructs the object.
   */
  public function __construct(\Traversable $namespaces, CacheBackendInterface $cache_backend, ModuleHandlerInterface $module_handler) {

FILE: src/Form/QuestionAnswerTypeForm.php

  /**
   * Form constructor.
   *
   * @param \Drupal\Component\Plugin\PluginManagerInterface $pluginManager
   *   The plugin manager.
   */
  public function __construct(

FILE: src/Form/QuestionResponseTypeForm.php

  /**
   * Form constructor.
   *
   * @param \Drupal\Component\Plugin\PluginManagerInterface $pluginManager
   *   The plugin manager.
   */
  public function __construct(

FILE: src/Form/QuestionTypeForm.php

  /**
   * Form constructor.
   *
   * @param \Drupal\Component\Plugin\PluginManagerInterface $pluginManager
   *   The plugin manager.
   * @param \Drupal\Core\Entity\EntityTypeManagerInterface $entityTypeManager
   *   The entity type manager.
   */
  public function __construct(

FILE: src/Form/QuizResultReviewForm.php

  /**
   * Form constructor.
   *
   * @param \Drupal\quiz_maker\Service\QuizHelper $quizHelper
   *   The quiz helper service.
   * @param \Drupal\quiz_maker\Service\QuizResultManager $quizManager
   *   The quiz manager.
   * @param \Drupal\Core\Logger\LoggerChannelFactoryInterface $loggerChannelFactory
   *   The logger factory.
   */
  public function __construct(

FILE: src/Form/QuizTakeForm.php

  /**
   * Form constructor.
   */
  public function __construct(

FILE: src/Plugin/Field/FieldFormatter/QuestionResponseFormatter.php

  /**
   * {@inheritdoc}
   */
  public function __construct(

FILE: src/Plugin/Field/FieldFormatter/TimeLimitFormatter.php

  /**
   * {@inheritdoc}
   */
  public function __construct(

The documentation comment for constructors is not mandatory anymore, If it is given, the description must be Constructs a new [class name] object. where [class name] includes the class namespace.

Rest looks fine to me.

Let’s wait for a Code Review Administrator to take a look and if everything goes fine, you will get the role.

Thank you for your contribution!
I updated your account so you can now opt into security advisory coverage for any project you created and every project you will create.

These are some recommended readings to help you with maintainership:

• Dries' post on Responsible maintainers
• Maintainership
• Git version control system
• Issue procedures and etiquette
• Maintaining and responding to issues for a project
• Release naming conventions.

You can find more contributors chatting on Slack or IRC in #drupal-contribute. So, come hang out and stay involved!

Thank you for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank also the dedicated reviewers as well.