Problem/Motivation

BlankSource.php contains a supportsParserType() method:

  /**
   * {@inheritdoc}
   */
  public function supportsParserType($parser_type) {
    // All parsers are supported by this custom source type.
    return TRUE;
  }

However, this is never called anywhere, and it is not part of the extended class CustomSourceBase. I only found it because I was debugging a class that extends it (JsonSource.php).

Therefore, I propose that it be removed.

Issue fork feeds-3442558

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

ptmkenny created an issue. See original summary.

ptmkenny’s picture

Status: Active » Needs review

MegaChriz made their first commit to this issue’s fork.

  • MegaChriz committed 6a9c67b1 on 8.x-3.x authored by ptmkenny
    Issue #3442558 by ptmkenny: Removed unused method BlankSource::...
megachriz’s picture

Status: Needs review » Fixed

I see, it must be a left over from an earlier implementation of the custom source UI. I merged the code!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.