Problem/Motivation

Steps to reproduce

navigation logo is not really communicated where the link is taking the user.
currently: output is an A tag with an image with alt text. No other string in link.

Proposed resolution

-use role="presentation" aria-hidden="true" for img/svg. (remove alt, aria-label)
-add hidden text in A tag. phrase Home page

Homepage is a neutral phrase whether the user is currently on the active path or user is in deeper breadcrumb location.

Remaining tasks

User interface changes

none

API changes

none

Data model changes

none

CommentFileSizeAuthor
#25 logo.mp457.31 KBrkoller

Issue fork drupal-3441586

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Issue fork navigation-3441586

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

SKAUGHT created an issue. See original summary.

skaught’s picture

UX/A11Y questions:
- should we change the img to decorative and remove alt. USE: role="presentation" aria-hidden="true".
- svg will be using 'aria-label' -- as above.

skaught’s picture

Status: Active » Needs review
Issue tags: +Needs usability review
skaught’s picture

Issue summary: View changes
skaught’s picture

Issue summary: View changes
rkoller’s picture

about the question should the logo be decorative or not. probably making the icon decorative might be the right step. www.tpgi.com and www.deque.com for example are using the alt attribute while the www.a11yproject.com is using the aria-hidden=true attribute for the logo. in case of tpgi and deque, those are both companies and they try to communicate that their company branding is in place here. but in the case of the navigation module knowing that there is an icon doesnt provide any extra benefit, to do it properly you would even have to describe it, that you are seeing a blueish rectangular button with rounded edges with a white drupal drop logo (since in this form it isnt used anywhere else). so making it decorative and focus on the link's purpose i might consider in the context of a navigation menu the better choice.

in regards of the label. going with just Homepage i am not sure if that is that clear. In the old admin toolbar you had Back to site. That made it clear that you are going somewhere entirely else. With homepage one might question are you going to /admin or what does Homepage refer to?
Adding a detail that you are going to the landing page of your default theme in the front end might clarify things. So i wonder maybe go with something like Frontpage default theme or Homepage default theme. That would include for one that you go to the frontpage/homepage and that it is the frontpage/homepage of the default theme. but "default theme" could also be too abstract in case the user is unaware of the concept of the default theme in drupal. as an alternative you could use the installed theme's name instead, but that could also throw off the user. Or even return to the label that was used in the admin toolbar and go with Back to site or completely different option that was not raised yet?

skaught’s picture

IMO: 'default theme' info is too much info.. i understand the thought.

we have talked about toolbar and 'back to site' which itself has additional redirect logic (which others also thought is actually confusing as the landing point then is in consistant..).

'back to site': means nothing if you are already on the homepage, thus (as an english phrase) 'homepage' feels like it will work without having to dynamically change the title on . of course, hoping to avoid 'frontpage' (:
-> should we switch the title when on the path? maybe this is the problem.

ckrina’s picture

Project: Navigation » Drupal core
Version: 1.x-dev » 11.x-dev
Component: Code » navigation.module
Status: Needs review » Needs work

Moving to Needs work after getting Navigation into core.

SKAUGHT changed the visibility of the branch 3441586-navigation-logo-does to hidden.

SKAUGHT changed the visibility of the branch 3441586-navigation-logo-does to hidden.

SKAUGHT changed the visibility of the branch 3441586-navigation-logo-does to active.

ckrina’s picture

Issue tags: +Portland2024

Gauravvvv made their first commit to this issue’s fork.

gauravvvv’s picture

Status: Needs work » Needs review
smustgrave’s picture

Status: Needs review » Needs work

Think the MR needs to be opened.

Also feels like something we can add a test assertion somewhere to an existing test, if one exists know the tests are still WIP.

Mithun S made their first commit to this issue’s fork.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

rkoller’s picture

mherchel’s picture

Issue summary: View changes

Had Zoom with @mgifford, @rkoller, and @kat-shaw.

We agree that the current proposed resolution is correct. “Home page” is an appropriate word to communicate the intentions. We added the space between the two words to ensure that the screen reader announces it properly.

mgifford’s picture

We agreed that this was a stable blocker.

mherchel’s picture

I updated the text and made some more minor changes, but having issues pushing. Going to try to do a new fork.

Edit: Got the push working

mherchel’s picture

Title: navigation Logo does not communicated where the link is taking the user » Navigation logo link does not communicated where it is taking the user
Status: Needs work » Needs review
Issue tags: -Needs usability review

OK. This should be ready to go.

rkoller’s picture

StatusFileSize
new57.31 KB

tested and looks good (see logo.mp4 - with safari and voiceover). even though i have to admit for me as a none native speaker "home page" looks quite odd, i have the urge to make it one single word, but rechecked dictionnaries and the two worded variant is the preferable one.

smustgrave’s picture

Status: Needs review » Reviewed & tested by the community

Changes in the MR LGTM and believe don’t hit requirement for tests.

Maybe a comment could be added but even that could be overkill?

  • catch committed 35671e56 on 11.x
    fix: #3441586 Navigation logo link does not communicated where it is...

  • catch committed e9a60b01 on main
    fix: #3441586 Navigation logo link does not communicated where it is...
catch’s picture

Version: main » 11.x-dev
Status: Reviewed & tested by the community » Fixed

This looks fine to me as-is.

I credited katannshaw per #21 and hope that's the right kat shaw - if not apologies and please let me know.

Committed/pushed to main and 11.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

mherchel’s picture

I credited katannshaw per #21 and hope that's the right kat shaw

That is correct. Thanks for checking!

One step closer! 🙌

catch’s picture

Title: Navigation logo link does not communicated where it is taking the user » Navigation logo link does not communicate where it is taking the user

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.