Problem/Motivation

The external libraries are out-of-date.

Proposed resolution

Update them.

Remaining tasks

Create a child issue for each library.

User interface changes

Some library updates may change their UI.

API changes

None.

Data model changes

None.

Issue fork webform-3441303

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jrockowitz created an issue. See original summary.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Version: 6.2.x-dev » 6.3.x-dev

paulrooney made their first commit to this issue’s fork.

paulrooney opened merge request !748

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Status: Active » Needs work

Tests are not passing.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Related issues: +#3511438: Update svg-pan-zoom library to v3.6.2
liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Related issues: +#3588624: Upgrade the select2 library
sarahjean’s picture

sarahjean commented

Are there any blockers that need looked at on this? The version of jQuery: International Telephone Input 17.0.19 on here is getting flagged by our firewall as having a virus, so the entire merge of composer.libraries.json is failing. I am not sure we are using it so could probably toggle it off and use one of the alternative library methods but it would be good to be getting more recent dependencies in the project in general.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

There ought to be a review by a user of each library that the new version works. This is part of why I think everything that uses an external library should be its own project that can focus on that integration.

sarahjean’s picture

sarahjean commented

Yeah that makes sense. I will see if I can help with testing then

jrockowitz’s picture

jrockowitz commented

We also need to update https://www.drupal.org/sandbox/jrockowitz/2941983

@see https://git.drupalcode.org/project/webform/-/blob/6.3.x/docs/UPDATE-LIBR...

I agree; any library with a major version upgrade will require some testing with minimal fixes.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Issue summary: View changes
Related issues: -#3511438: Update svg-pan-zoom library to v3.6.2, -#3588624: Upgrade the select2 library