By dipakmdhrm on
Change record status: 
Published (View all published change records)
Project: 
Drupal core
Introduced in branch: 
10.3.x
Introduced in version: 
10.3.0
Issue links: 
https://www.drupal.org/node/3439580
Description: 

tableheader.js has been removed

.sticky-enabled class used by tableheader.js has been removed too.
Any code using .sticky-enabled class in JS or CSS should be updated to use .sticky-header class instead

ClaroPreRender::tablePositionSticky method has been removed

css/components/sticky-header.module.css has been moved to misc/components/sticky-header.module.css and is included in the core/drupal.tableheader library.
Themes using libraries-override to replace these CSS files will need to update for the new library locations. See for example this change in stable9:

diff --git a/core/themes/stable9/stable9.info.yml b/core/themes/stable9/stable9.info.yml
index dd81e74177..49c52f0064 100644
--- a/core/themes/stable9/stable9.info.yml
+++ b/core/themes/stable9/stable9.info.yml
@@ -96,6 +96,11 @@ libraries-override:
         misc/components/tabledrag.module.css: css/core/components/tabledrag.module.css
         misc/components/tree-child.module.css: css/core/components/tree-child.module.css
 
+  core/drupal.tableheader:
+    css:
+      component:
+        misc/components/sticky-header.module.css: css/system/components/sticky-header.module.css
+
   core/drupal.vertical-tabs:
     css:
       component:
@@ -243,7 +248,6 @@ libraries-override:
         css/components/position-container.module.css: css/system/components/position-container.module.css
         css/components/reset-appearance.module.css: css/system/components/reset-appearance.module.css
         css/components/resize.module.css: css/system/components/resize.module.css
-        css/components/sticky-header.module.css: css/system/components/sticky-header.module.css
         css/components/system-status-counter.css: css/system/components/system-status-counter.css
         css/components/system-status-report-counters.css: css/system/components/system-status-report-counters.css
Impacts: 
Module developers
Themers

Comments

mrogers’s picture

mrogers commented

Should this line:

css:
  component:
    misc/components/sticky-header.module.css: css/system/components/sticky-header.module.css

Actually be:

css:
  component:
    css/components/sticky-header.module.css:
      component: misc/components/sticky-header.module.css

I get an error otherwise: TypeError: array_key_first(): Argument #1 ($array) must be of type array, string given in array_key_first() (line 455 of /app/web/core/lib/Drupal/Core/Asset/LibraryDiscoveryParser.php).