This issue will bring the phase 1 Recipes project into core. The MR includes all the fixed issues from the recipes queue - see https://www.drupal.org/project/issues/search/distributions_recipes?proje...
@todo
#3439702: Allow CLI install of Drupal using recipes
#3439918: Add a core/core.recipes.api.php file
#3427558: Output information from the recipe application process
And any other issues tagged in the queue with core-mvp - see https://www.drupal.org/project/issues/search/distributions_recipes?proje...
None
The MR adds 4 new APIs. There are:
Recipe depends on DefaultContent, Action and Checkpoint. The other new APIs have no interdependencies.
None
@todo
Ideally create a core-mvp issue in https://www.drupal.org/project/issues/distributions_recipes and address there first and one of the recipes initiative leads will merge in into this the fork and then into this MR>
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes, plain diff MR !7908changes, plain diff MR !7410
Comments
Comment #15
alexpottAdding the people who contributed the issues that are committed to the recipe repo as contributors here.
Comment #17
alexpottComment #18
alexpottComment #20
alexpottComment #22
alexpottComment #23
larowlanLeft a review.
You mentioned the other night we could split the APIs up and put them in separately - e.g. the default content api, the config actions stuff.
But reviewing it with gitlab wasn't horrible so I'm not fussed either way.
Comment #25
alexpottCrediting people of who have been credited in the recipes initiative queue recently.
Comment #27
alexpottCrediting people of who have been credited in the recipes initiative queue recently.
Comment #28
alexpottComment #29
thejimbirch commentedGoing to move this to RTBC. All the feedback from @larowlan has been addressed, and out last outstanding issue is being reviewed by @alexpot.
Comment #30
thejimbirch commentedComment #31
wim leersResponded to ~half a dozen threads.
And did a review pass myself too over the parts I had not seen before. Two questions I have:
InstallCommandlooks like a BC break? https://git.drupalcode.org/project/drupal/-/merge_requests/7410#note_306489revision_translation_affectedin the default content YAML if it's a read-only field? https://git.drupalcode.org/project/drupal/-/merge_requests/7410#note_306499Comment #32
phenaproximaRegarding #31.2: it's exported by the default_content module, which is what generates these YAML files. IMHO they should not be changed at this time, but if (which, once this is committed, is really when) core adds the ability to export content entities as YAML, then it may make sense to omit certain fields, like revision_translation_affected.
Comment #34
alexpottCreditting longwave for review
Comment #35
longwaveDid a second pass, nothing much to add except some small nits - happy to defer many of them to followups if that helps.
Comment #36
alexpottI've addressed/applied @longwave's review - thanks! - great spot on the array_diff. As these were small nits setting back to rtbc.
Comment #37
longwaveSome test failures following the change to encode/decode.
Comment #38
alexpottFixed the tests - it was pretty simple so back to RTBC.
Comment #39
alexpottComment #40
mondrakeCan you please make dataproviders
staticso we don’t mess up with PHPUnit 10 upgrade ?Comment #41
longwaveGreat catch in #40.
Comment #42
alexpottResolved #40 in https://git.drupalcode.org/project/drupal/-/merge_requests/7410/diffs?co... - as this is only about staticness - back to rtbc.
Comment #43
longwaveWill need a separate MR for 10.3.x/10.4.x:
11.x is also currently frozen but this could be committed there when it's unfrozen and then backported later to 10.4/10.3, so leaving at RTBC for now.
Comment #45
alexpottWe maintain a 10.3.x version of recipes so that's no problem to push here... which I've done so #43 is done so I guess this can be back to rbtc once we see green on the 10.3.x test run.
Comment #46
alexpottwe're green on 10.3.x
Comment #50
longwaveThanks to everyone who contributed here, and congratulations on landing this, can't wait to see what we can do in the future now this is available in core.
Committed 74da82a and pushed to 11.x. Thanks!
Committed and pushed 54be1ad9d2 to 10.4.x and a15d5540c6 to 10.3.x. Thanks!
Comment #52
gábor hojtsyPublished the draft CR at https://www.drupal.org/node/3445169