Problem/Motivation

Currently we use gc-thickline style for our H1 but only when using the lead title. Now that CDS/Canada.ca has this as the default for all pages, we should make gc-thickline the default H1 styling globally.

GCWeb PR - https://github.com/wet-boew/GCWeb/pull/2169

CommentFileSizeAuthor
#7 wxt_bootstrap-default_gc_thickline-3436553-7.patch1021 bytesliam morland
#4 wxt_bootstrap-default_gc_thickline-3436553-3.patch975 bytesliam morland

Comments

smulvih2 created an issue. See original summary.

robingalipeau’s picture

robingalipeau commented

Hi Stephen,

So is this what Liam can commit... Based on email thread?

/**
 * Implements hook_preprocess_page_title().
 */
function MY_THEME_preprocess_page_title(&$variables) {
  $variables['gc_thickline'] = TRUE;
}
smulvih2’s picture

smulvih2
Location Canada 🍁
commented

No, this is currently how to set the gc-thickline if not using lead title. To make gc-thickline the default used, he will need to change the page-title.html.twig file in wxt_bootstrap, plus review wxt_bootstrap.theme for any gc-thickline logic.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
StatusFileSize
new wxt_bootstrap-default_gc_thickline-3436553-3.patch975 bytes

The attached patch to wxt_bootstrap makes gc-thickline the default by adjusting the template. gc_thickline can be set to false to avoid this if needed.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

or, just upgrade to GCWeb 14.5.0 , no change to twig is needed.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

See this commit

https://git.drupalcode.org/project/wxt_library/-/commit/e7d754930eaecb91...

It'll be in the next release.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Status: Active » Needs review
StatusFileSize
new wxt_bootstrap-default_gc_thickline-3436553-7.patch1021 bytes

More robust patch.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Parent issue: » #3422762: theme-gcweb GCWeb 14.5.0 upgrade
joseph.olstad’s picture

joseph.olstad
Primary language French
commented

this patch will conflict with the GCWeb 14.5.0 upgrade

smulvih2’s picture

smulvih2
Location Canada 🍁
commented

@joseph you are correct, the GCWeb PR attached show that they have remoed h1.gc-thickline and now the style applies to the plain H1.

sylus’s picture

sylus commented
Status: Needs review » Fixed

Committed and attributed!

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

I'm not 100% sure however I did back off the thickline from our css when using GCWeb 14.5.0 , it is not needed. 100% sure that it's not needed.

What I also am actually concerned with, this change may actually cause a regression and result in a double underline when used in combination with GCWeb 14.5.0.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.