Problem/Motivation

To test out the GCWeb upgrade quickly, run this script from the root of your project:

#!/bin/bash
if [ -d "html/libraries" ]; then
  echo "Begin upgrade of gcweb library from 10.something to 14.5.0 and wet-boew from 4.0.50 to 4.0.74."
  pushd html/libraries;
  rm tmp -rf;
  mkdir tmp;
  pushd tmp;
  wget https://github.com/wet-boew/wet-boew/releases/download/v4.0.74/wet-boew-dist-4.0.74.zip
  wget https://github.com/wet-boew/GCWeb/releases/download/v14.5.0/themes-dist-14.5.0-gcweb.zip
  unzip wet-boew-dist-4.0.74.zip
  mv ../wet-boew wet-boew_orig
  mv wet-boew-dist-4.0.74/wet-boew ../
  unzip themes-dist-14.5.0-gcweb.zip
  mv ../theme-gcweb theme-gcweb_orig
  mv themes-dist-14.5.0-gcweb/GCWeb ../theme-gcweb
  popd
  rm ../libraries/tmp -r;
  popd;
  echo "End of upgrade for the gcweb library, now upgraded to gcweb 14.5.0 and wet-boew 4.0.74."
fi

drush cr

WxT gcweb: Feb 2022 - version 10.5.0

WxT wet-boew: May 2022 - version 4.0.50

Latest gcweb: v14.5.0

Latest wet-boew: v4.0.74

last update 10.5.0 was Feb 2022
Manually upgraded the libraries/wet-boew and libraries/theme-gcweb for a test run.
also did wet-boew from 4.0.50 to 4.0.74
Just testing quickly 14.5.0 with a gcweb internet theme along with wet-boew 4.0.74, it's holding up decently.
manual setup of downloading and moving the expected folder into place , rebuild caches.

Before and After upgrading from 10.5.0 to 14.5.0 screenshot

should target the upgrade for gcweb, I imagine things could possibly be lost or broken for other modes other than gcweb.

Not sure if they fixed the reported issues we had previously reported but it doesn't look any worse than 10.5.0

Steps to reproduce

install wxt
upgrade wet-boew and theme-gcweb

Proposed resolution

review plan

Remaining tasks

review

User interface changes

Hopefully mostly compatible

API changes

theme js and css

Data model changes

N/A

CommentFileSizeAuthor
#15 wxt_bootstrap-3422762-15.patch1.3 KBjoseph.olstad
#15 interdiff_12_to_15.txt701 bytesjoseph.olstad
#13 wxt_bootstrap-3422762-12.patch1.17 KBjoseph.olstad
#3 gcweb14x5x0.png20.38 KBjoseph.olstad

Comments

joseph.olstad created an issue. See original summary.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Issue summary: View changes
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Issue summary: View changes
StatusFileSize
new gcweb14x5x0.png20.38 KB
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Issue summary: View changes
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Issue summary: View changes
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Issue summary: View changes
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Issue summary: View changes
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Issue summary: View changes
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Issue summary: View changes
sylus’s picture

sylus commented

I have upgraded wet-boew to v4.0.74 and theme-gcweb to v14.5.0 and all seems to still look good and function correctly.

sylus’s picture

sylus commented
Status: Active » Fixed
joseph.olstad’s picture

joseph.olstad
Primary language French
commented

GCWeb 14.5+ css fixes are needed:

Breadcrumb in mobile left alignment 

ol.breadcrumb {
  margin-left: 20px;
}
@media screen and (max-width: 767px) {
  ol.breadcrumb {
    margin-left: 30px;
  }
}

Double parliament fix in the footer

#wb-info {
  .gc-main-footer {
    background: none;
  }
}

This pretty much covers it.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Fixed » Needs review
StatusFileSize
new wxt_bootstrap-3422762-12.patch1.17 KB

See patch

sylus’s picture

sylus commented

Ah so these fixes do solve the problem but this usually means some of the markup must have slightly changed since the gcweb updates.

If we can find the markup changes that occurred in this region and match it again, then we shouldn't need to fix this with CSS.

I'll try to take a further look but it might not be for a couple of days but for now the css fix works for those want to try it out. :)

Thanks so much!

Thanks for reminding me to update this theme.

I need to make it so composer-extdeps generates based on themes-cdn releases but for now its a manual task. :(

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
StatusFileSize
new interdiff_12_to_15.txt701 bytes
new wxt_bootstrap-3422762-15.patch1.3 KB

New patch

aligns breadcrumb to content margin

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Title: theme-gcweb upgrade » theme-gcweb GCWeb 14.5.0 upgrade
sylus’s picture

sylus commented
Status: Needs review » Fixed

I made releases for wxt_bootstrap and wxt_library as well as making the needed markup changes so we weren't getting the duplicate parliament banner in the footer. :)

Thanks for the help in tracking all of this down!

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

Cool thanks, d.o no longer makes it easy to credit author. I've been meaning to create an issue in the d.o project page

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.