Problem/Motivation

Error during drush site:install --existing-config:

Call to a member function getConfigDependencyName() on null

Proposed resolution

Wrap tmgmt_local_install code with !\Drupal::isConfigSyncing() check

CommentFileSizeAuthor
#6 3436093-6-tmgmtlocalinstall-should-check.patch1.66 KBplov

Issue fork tmgmt-3436093

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Leksat created an issue. See original summary.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

hook_install() implementations get a $is_syncing parameter. It is sufficient to check its value, like forum_install() does.

apaderno opened merge request !61

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Active » Needs review
leksat’s picture

leksat commented
Status: Needs review » Reviewed & tested by the community

@apaderno Even better 🎉 Thanks!

The MR looks good and solves the issue ✅

plov’s picture

plov commented
StatusFileSize
new 3436093-6-tmgmtlocalinstall-should-check.patch1.66 KB

Moved changes to the patch

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 6: 3436093-6-tmgmtlocalinstall-should-check.patch, failed testing. View results

pfrenssen made their first commit to this issue’s fork.

pfrenssen’s picture

pfrenssen
Location Sofia
commented
Status: Needs work » Reviewed & tested by the community

Looks good and solves the problem! I only updated the pipeline so the tests can run, so I think it is OK for me to RTBC this.

berdir made their first commit to this issue’s fork.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Reviewed & tested by the community » Fixed

Better to do fixes like the webform change in separate issues, conflicted now. Rebased through the UI and adding to the merge train.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • berdir committed db357cd1 on 8.x-1.x authored by avpaderno 
    fix: #3436093 tmgmt_local_install() should check \Drupal::...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.