Problem/Motivation

Fix warnings reported by PHPStan job
Latest PHPStan job- https://git.drupalcode.org/issue/jsonapi_extras-3451984/-/jobs/1962253

Issue fork jsonapi_extras-3435834

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

gaurav_manerkar created an issue. See original summary.

ankitv18 made their first commit to this issue’s fork.

ankitv18’s picture

ankitv18 commented
Assigned: Unassigned » ankitv18
gaurav_manerkar’s picture

gaurav_manerkar commented

PHPStan errors - https://git.drupalcode.org/issue/jsonapi_extras-3435832/-/jobs/1714573

ankitv18’s picture

ankitv18 commented
Issue summary: View changes

ankitv18 opened merge request !49

ankitv18’s picture

ankitv18 commented
Assigned: ankitv18 » Unassigned
Status: Active » Needs review

All phpstan and phpcs issues are fixed which are reported in their pipelines.
@bbrala can you please review MR!49 and merge if possible.

ptmkenny’s picture

ptmkenny commented
Category: Bug report » Task
Status: Needs review » Needs work

I did a basic review of the code. Marking "Needs work" based on the addition of a dependency that I don't think is actually required.

ankitv18’s picture

ankitv18 commented
Status: Needs work » Needs review

Made the changes as per feedback ~~ Pipeline are running perfectly fine
@bbrala please review at your end.

ptmkenny’s picture

ptmkenny commented

Did another review. Leaving it at "Needs review" as @bbrala is the maintainer and should also review this.

ankitv18’s picture

ankitv18 commented
Parent issue: » #3451984: Automated Drupal 11 compatibility fixes for jsonapi_extras
ankitv18’s picture

ankitv18 commented
Assigned: Unassigned » ankitv18
Status: Needs review » Needs work
ankitv18’s picture

ankitv18 commented
Issue summary: View changes

ankitv18 opened merge request !55

ankitv18 changed the visibility of the branch 3435834-fix-warnings-reported to hidden.

ankitv18’s picture

ankitv18 commented
Assigned: ankitv18 » Unassigned
Status: Needs work » Needs review

@bbrala please review MR!55

benstallings’s picture

benstallings commented

I'm now seeing,

------ ----------------------------------------------------------------------------
Line tests/src/Kernel/EntityToJsonApiTest.php
------ ----------------------------------------------------------------------------
153 Method
Drupal\Tests\jsonapi_extras\Kernel\EntityToJsonApiTest::createImageField()
invoked with 2 parameters, 3-8 required.
------ ----------------------------------------------------------------------------

bbrala made their first commit to this issue’s fork.

bbrala’s picture

bbrala
Location Netherlands
commented
Status: Needs review » Fixed

Thanks all! I've fixed a few more small things extra :)

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

  • bbrala committed c5a71df0 on 8.x-3.x authored by ankitv18 
    [#3435834] fix: Fix warnings reported by PHPStan job

By: ankitv18
By:...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.