Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 11.

Changes will periodically be added to this issue that remove deprecated API uses. To stop further changes from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD11" tag from the issue to stop the bot from posting updates.

The changes will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated changes until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD11" tag is left on this issue, new changes will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the changes posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot changes. The bot will still post new changes then if there is a change in the new generated patch compared to the changes that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated changes.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated changes, remove the "ProjectUpdateBotD11" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated changes again, add back the "ProjectUpdateBotD11" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated changes will be posted here.

    If the issue is reopened, then new automated changes will be posted.

    If you are using another issue(s) to work on Drupal 11 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Using the merge request

  1. Review the merge request and test it.
  2. Thoroughly test the changes. These changes are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the merge request, create a new branch and merge request and work from there.

Warning: The 'project-update-bot-only' branch will always be overwritten. Do not work in that branch!

Providing feedback

If there are problems with one of the changes posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.

CommentFileSizeAuthor
#2 webform_revision_ui.1.0.0-alpha3.rector.patch442 bytesproject update bot

Issue fork webform_revision_ui-3435672

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Project Update Bot created an issue. See original summary.

project update bot’s picture

project update bot commented
Status: Active » Needs review
StatusFileSize
new webform_revision_ui.1.0.0-alpha3.rector.patch442 bytes

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update the info.yml file for Drupal 11 compatibility.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

Bot run #11-127659

These packages were used to generate the fixes:

  1. drupal/upgrade_status: 4.1.0
  2. mglaman/phpstan-drupal: 1.2.9
  3. palantirnet/drupal-rector: 0.20.1

Project Update Bot opened merge request !3

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Issue summary: View changes

Going to combine the various D10 fixes, required by D11.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Parent issue: » #3451887: Automated Drupal 11 compatibility fixes for config_revision
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Needs review » Postponed

PLEASE COMMIT/MERGE THE DRUPAL 11 FIX FOR the config_revision MODULE FIRST.

The config_revision module is required by webform_revision_ui however the automated tests will not load it as there is currently no advertised Drupal 11 compatible version of the config_revision module.

Chicken and the egg. First commit/merge this RTBC Drupal 11 fix.
#3451887: Automated Drupal 11 compatibility fixes for config_revision

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Postponed » Needs review

config_revision now has a D11 upgrade ready

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

I'll reach out to the maintainers (again?) to let them know we can merge.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Needs review » Reviewed & tested by the community
joseph.olstad’s picture

joseph.olstad
Primary language French
commented

I sent friendly messages asking for D11 fix to these maintainers:
@Jibran
@mortim07
@nterbogt

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Reviewed & tested by the community » Needs work

The changes look good. Let's address some cosmetic comments, and then we are good to go.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Assigned: Unassigned » joseph.olstad
Status: Needs work » Active

I'll update this tonight.

smustgrave’s picture

smustgrave commented

Question what does adding permissions have to do with D11 release?

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

@smustgrave, there's important fixes mixed in that affect/improve the automated testing that we have set up for the Drupal 11 upgrade.

Rather than unwind, would prefer we move forward with these (included).

My bad though, I should have done a better job on the commit messages crediting the other issues. Not sure how I missed that.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Assigned: joseph.olstad » Unassigned
Status: Active » Needs review

Test results are good, both automated and manual tests.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Version: 1.0.0-alpha3 » 1.0.x-dev

All green!

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs review » Needs work

Left some review comments.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Needs work » Reviewed & tested by the community

I like the suggested changes.
Still all green!

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

@jibran , please credit everyone from

#3328890: Revisions tab shows up when the anonymous user accesses the Webforms

And

#3380657: Use the magic method instead of "versionHistory" method from VersionHistoryController class

These are the usernames of all the contributors from those issues:
jamesyao , mohit_aghera , progga , smulvih2 , jibran

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Reviewed & tested by the community » Needs work

We need per operation to permission test.

we can't commit this until we add all the tests.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

@jibran, we're already testing anonymous and editor in new tests

https://git.drupalcode.org/project/webform_revision_ui/-/merge_requests/...

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented

Yes, we also need to test per permission and make sure all the operations are supported by newly added permissions.

mohit_aghera changed the visibility of the branch project-update-bot-only to hidden.

mohit_aghera changed the visibility of the branch project-update-bot-only to active.

mohit_aghera’s picture

mohit_aghera commented
Status: Needs work » Needs review

Tests added for permissions https://git.drupalcode.org/project/webform_revision_ui/-/merge_requests/....
PR is green now.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Needs review » Reviewed & tested by the community

Looks great, thanks! Any greener than this and you'd need to get a lawnmower to start cutting the grass.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

@jibran, it's literally perfect now, please review again!

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

@jibran, please merge this Drupal 11 release fix and please also tag a release.

This module is one of our few remaining override modules and we'd prefer to normalize this situation.

Extensive testing has been performed over the past 2 months. No issues with this module running against Drupal 11.1.3.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Reviewed & tested by the community » Needs work

Thank you for working on the feedback. I have left a few comments. Let's fix them.

Can we have better user variable names rather than user1, user2, and user?

mitrpaka made their first commit to this issue’s fork.

mitrpaka’s picture

mitrpaka commented
Status: Needs work » Needs review

Converted WebformRevisionUiAccessTest to a functional test to ensure full Drupal request handling, as kernel tests don't automatically execute hook implementations.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

@maintainers , please action this!

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

We're deep into the third minor of Drupal 11 (the first being 11.0.x, second 11.1.x and the third 11.2.x)

It's time to release a this module for Drupal 11 please!

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs review » Reviewed & tested by the community

@mitrpaka Thank you for updating the test. It seems like we caught a real bug.

@@ -132,5 +132,5 @@ function webform_revision_ui_config_revision_access(EntityInterface $config_rev_
- return AccessResult::neutral();
+ return AccessResult::forbidden();
}

  • jibran committed 1723fdf4 on 1.0.x 
    Issue #3435672 by joseph.olstad, project update bot, mohit_aghera,...
jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Reviewed & tested by the community » Fixed

Thank you all for your work and patience. The patch is committed and pushed to 1.0.x.

jibran closed merge request !3

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented

Also created https://www.drupal.org/project/webform_revision_ui/releases/1.0.0-beta1

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.