Automated Drupal 11 compatibility fixes for tome [#3435061]

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 11.

Changes will periodically be added to this issue that remove deprecated API uses. To stop further changes from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD11" tag from the issue to stop the bot from posting updates.

The changes will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

Accept automated changes until this issue is closed
If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD11" tag is left on this issue, new changes will be posted periodically if new deprecation fixes are needed.

As the Drupal Rector project improves and is able to fix more deprecated API uses, the changes posted here will cover more of the deprecated API uses in the module.

Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot changes. The bot will still post new changes then if there is a change in the new generated patch compared to the changes that the bot posted last. Those changes are then up to humans to integrate.
Leave open but stop new automated changes.
If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated changes, remove the "ProjectUpdateBotD11" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated changes again, add back the "ProjectUpdateBotD11" tag.
Close it and don't use it
If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated changes will be posted here.

If the issue is reopened, then new automated changes will be posted.

If you are using another issue(s) to work on Drupal 11 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Using the merge request

Review the merge request and test it.
Thoroughly test the changes. These changes are automatically generated so they haven't been tested manually or automatically.
Provide feedback about how the testing went. If you can improve the merge request, create a new branch and merge request and work from there.

Warning: The 'project-update-bot-only' branch will always be overwritten. Do not work in that branch!

Providing feedback

If there are problems with one of the changes posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.

Comment	File	Size	Author
#24	tome.1.x-dev.upgrade_status.post_rector.txt	2.5 KB	project update bot
#24	tome.1.x-dev.rector.patch	35.04 KB	project update bot
#24	interdiff-last-bot.6956860.txt	546 bytes	project update bot
#5	tome.1.x-dev.upgrade_status.post_rector.txt	13.56 KB	project update bot
#5	tome.1.x-dev.rector.patch	35.67 KB	project update bot
#5	interdiff-last-bot.6950567.txt	11.46 KB	project update bot
#4	tome.1.x-dev.upgrade_status.post_rector.txt	13.56 KB	project update bot
#4	tome.1.x-dev.rector.patch	34.83 KB	project update bot
#4	interdiff-last-bot.6917795.txt	659 bytes	project update bot
#2	tome.8.x-1.12.upgrade_status.post_rector.txt	17.9 KB	project update bot
#2	tome.8.x-1.12.rector.patch	33.8 KB	project update bot

Issue fork tome-3435061

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

project-update-bot-only changes, plain diff MR !27 / changes, plain diff MR !23
Check out this branch for the first time

Check out existing branch, if you already have it locally
3435061-automated-drupal-11 compare
Check out this branch for the first time

Check out existing branch, if you already have it locally

1 hidden branch

tome-3435061-project-update-bot-only

compare

Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

25 March 2024 at 03:10

Project Update Bot created an issue. See original summary.

Comment #2

project update bot commented 25 March 2024 at 03:10

Status:

Active

» Needs review

Status	File	Size
new	tome.8.x-1.12.rector.patch	33.8 KB
new	tome.8.x-1.12.upgrade_status.post_rector.txt	17.9 KB

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module, even with these changes, this module is not yet compatible with Drupal 11.

Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.

Therefore these changes did not update the info.yml file for Drupal 11 compatibility.

The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

Bot run #11-127659

These packages were used to generate the fixes:

drupal/upgrade_status: 4.1.0
mglaman/phpstan-drupal: 1.2.9
palantirnet/drupal-rector: 0.20.1

Comment #3

25 March 2024 at 03:10

Project Update Bot opened merge request !23

Comment #4

project update bot commented 18 June 2024 at 04:33

Version:

8.x-1.12

» 8.x-1.x-dev

Status	File	Size
new	interdiff-last-bot.6917795.txt	659 bytes
new	tome.1.x-dev.rector.patch	34.83 KB
new	tome.1.x-dev.upgrade_status.post_rector.txt	13.56 KB

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module, even with these changes, this module is not yet compatible with Drupal 11.

Currently Drupal Rector, version 0.20.3, cannot fix all Drupal 11 compatibility problems.

Therefore, these changes did not update the info.yml file for Drupal 11 compatibility.

The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

Debug information

Bot run #11-199781

These packages were used to generate the fixes:

drupal/upgrade_status: 4.3.2
mglaman/phpstan-drupal: 1.2.11
palantirnet/drupal-rector: 0.20.3

Comment #5

project update bot commented 6 July 2024 at 21:07

Status	File	Size
new	interdiff-last-bot.6950567.txt	11.46 KB
new	tome.1.x-dev.rector.patch	35.67 KB
new	tome.1.x-dev.upgrade_status.post_rector.txt	13.56 KB

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module, even with these changes, this module is not yet compatible with Drupal 11.

Currently Drupal Rector, version 0.20.3, cannot fix all Drupal 11 compatibility problems.

Therefore, these changes did not update the info.yml file for Drupal 11 compatibility.

The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

Debug information

Bot run #11-217342

These packages were used to generate the fixes:

drupal/upgrade_status: 4.3.4
mglaman/phpstan-drupal: 1.2.11
palantirnet/drupal-rector: 0.20.3

Comment #6

17 July 2024 at 22:59

larowlan made their first commit to this issue’s fork.

Comment #7

17 July 2024 at 22:59

larowlan committed 940fd236 on 8.x-1.x authored by Project Update Bot

Issue #3435061: Automated Drupal 11 compatibility fixes for tome

Comment #8

larowlan

🇦🇺🏝.au GMT+10

commented 17 July 2024 at 23:00

Issue summary:

View changes

Gah I merged that by mistake, E_TOO_MANY_TABS

Going to revert it and reopen

Comment #9

17 July 2024 at 23:00

larowlan committed 76e31bbf on 8.x-1.x

Revert "Issue #3435061: Automated Drupal 11 compatibility fixes for tome...

Comment #10

17 July 2024 at 23:02

larowlan opened merge request !27

Comment #11

20 August 2024 at 00:16

realityloop made their first commit to this issue’s fork.

Comment #12

realityloop commented 20 August 2024 at 00:18

updated .ino.yml and composer.json to allow D11

Comment #13

29 September 2024 at 17:12

ivnish made their first commit to this issue’s fork.

Comment #14

ivnish

he/him

commented 29 September 2024 at 17:19

Status:

Needs review

» Needs work

After applying the path from MR I get

Symfony\Component\DependencyInjection\Exception\ServiceCircularReferenceException: Circular reference detected for service "router.route_provider", path: "options_request_listener -> router.route_provider -> cache_tags.invalidator -> cache.tome_static -> maintenance_mode_subscriber -> url_generator". in Drupal\Component\DependencyInjection\Container->get() (line 147 of core/lib/Drupal/Component/DependencyInjection/Container.php).

TypeError: Drupal\Core\Cache\DatabaseBackend::__construct(): Argument #4 ($serializer) must be of type Drupal\Component\Serialization\ObjectAwareSerializationInterface, int given, called in /var/www/web/modules/contrib/tome/modules/tome_static/src/StaticCache.php on line 30 in /var/www/web/core/lib/Drupal/Core/Cache/DatabaseBackend.php on line 88 #0 /var/www/web/modules/contrib/tome/modules/tome_static/src/StaticCache.php(30): Drupal\Core\Cache\DatabaseBackend->__construct(Object(Drupal\mysql\Driver\Database\mysql\Connection), Object(Drupal\Core\Cache\DatabaseCacheTagsChecksum), 'tome_static', -1)
#1 /var/www/web/core/lib/Drupal/Component/DependencyInjection/Container.php(259): Drupal\tome_static\StaticCache->__construct(Object(Drupal\mysql\Driver\Database\mysql\Connection), Object(Drupal\Core\Cache\DatabaseCacheTagsChecksum))

Comment #15

sourav_paul

Kolkata

commented 21 October 2024 at 07:11

Assigned:

Unassigned

» sourav_paul

Comment #16

sourav_paul

Kolkata

commented 21 October 2024 at 12:40

Assigned:

sourav_paul

» Unassigned

Even after creating an instance of serializer, as the 4th parameter in the DatabaseBackend::__construct method must be an instance of ObjectAwareSerializationInterface, facing this issue

ArgumentCountError: Too few arguments to function Drupal\tome_static\StaticCache::__construct(), 2 passed in /app/web/core/lib/Drupal/Component/DependencyInjection/Container.php on line 259 and exactly 3 expected in Drupal\tome_static\StaticCache->__construct() (line 33 of /app/web/modules/contrib/tome/modules/tome_static/src/StaticCache.php).

Comment #17

26 October 2024 at 14:31

mirom made their first commit to this issue’s fork.

Comment #18

26 October 2024 at 14:33

mirom changed the visibility of the branch tome-3435061-project-update-bot-only to hidden.

Comment #19

mirom commented 26 October 2024 at 14:42

Hi @sourav_paul and @ivnish, can you please share steps to replicate your issues? I installed the module into clean-ish Drupal site and after pushing my fixes, I was able to perform all operations through drush as well as in the UI.

Comment #20

realityloop commented 28 October 2024 at 01:20

@mirom

Using Foundry https://github.com/Realityloop/foundry

Getting the following error locally, the node in question doesn't have any added fields that are date fields:

brian@drupal-foundry-web:/var/www/html$ drush tome:install -y

 // You are about to DROP all tables in your local database and re-install Tome. Do you want to continue?: yes.         


In SiteProcess.php line 214:
                                                                                                                            
  The command "/var/www/html/vendor/bin/drush tome:import --yes --uri=https://drupal-foundry.ddev.site" failed.             
                                                                                                                            
  Exit Code: 1(General error)                                                                                               
                                                                                                                            
  Working directory:                                                                                                        
                                                                                                                            
  Output:                                                                                                                   
  ================                                                                                                          
                                                                                                                            
   [ERROR] Errors encountered when importing content:                                                                       
                                                                                                                            
   [ERROR] Error when running "'/var/www/html/vendor/bin/drush' 'tome:import-content'                                       
           'node.92365dea-5736-4f30-8b0b-c7e6b5585b98'":                                                                    
              [warning] Undefined array key "end_value" SmartDateNormalizer.php:40                                          
            [error]  Error: Call to a member function getTimestamp() on null in                                             
           Drupal\serialization\Normalizer\TimestampNormalizer->denormalize() (line 39 of                                   
           /var/www/html/web/core/modules/serialization/src/Normalizer/TimestampNormalizer.php) #0                          
           /var/www/html/web/modules/contrib/smart_date/src/Normalizer/SmartDateNormalizer.php(40):                         
           Drupal\serialization\Normalizer\TimestampNormalizer->denormalize()                                               
           #1 /var/www/html/vendor/symfony/serializer/Serializer.php(238):                                                  
           Drupal\smart_date\Normalizer\SmartDateNormalizer->denormalize()                                                  
           #2 /var/www/html/web/modules/contrib/smart_date/src/Normalizer/SmartDateItemNormalizer.php(45):                  
           Symfony\Component\Serializer\Serializer->denormalize()                                                           
           #3 /var/www/html/web/core/modules/serialization/src/Normalizer/FieldItemNormalizer.php(33):                      
           Drupal\smart_date\Normalizer\SmartDateItemNormalizer->constructValue()                                           
           #4 /var/www/html/vendor/symfony/serializer/Serializer.php(238):                                                  
           Drupal\serialization\Normalizer\FieldItemNormalizer->denormalize()                                               
           #5 /var/www/html/web/core/modules/serialization/src/Normalizer/FieldNormalizer.php(47):                          
           Symfony\Component\Serializer\Serializer->denormalize()                                                           
           #6 /var/www/html/vendor/symfony/serializer/Serializer.php(238):                                                  
           Drupal\serialization\Normalizer\FieldNormalizer->denormalize()                                                   
           #7 /var/www/html/web/core/modules/serialization/src/Normalizer/FieldableEntityNormalizerTrait.php(152):          
           Symfony\Component\Serializer\Serializer->denormalize()                                                           
           #8 /var/www/html/web/core/modules/serialization/src/Normalizer/EntityNormalizer.php(59):                         
           Drupal\serialization\Normalizer\EntityNormalizer->denormalizeFieldData()                                         
           #9 /var/www/html/vendor/symfony/serializer/Serializer.php(238):                                                  
           Drupal\serialization\Normalizer\EntityNormalizer->denormalize()                                                  
           #10 /var/www/html/web/modules/contrib/tome/modules/tome_sync/src/Importer.php(272):                              
           Symfony\Component\Serializer\Serializer->denormalize()                                                           
           #11 /var/www/html/web/modules/contrib/tome/modules/tome_sync/src/Importer.php(215):                              
           Drupal\tome_sync\Importer->loadEntityFromStorage()                                                               
           #12 /var/www/html/web/modules/contrib/tome/modules/tome_sync/src/Commands/ImportContentCommand.php(34):          
           Drupal\tome_sync\Importer->importContent()                                                                       
           #13 /var/www/html/vendor/symfony/console/Command/Command.php(279):                                               
           Drupal\tome_sync\Commands\ImportContentCommand->execute()                                                        
           #14 /var/www/html/vendor/symfony/console/Application.php(1047):                                                  
           Symfony\Component\Console\Command\Command->run()                                                                 
           #15 /var/www/html/vendor/symfony/console/Application.php(316):                                                   
           Symfony\Component\Console\Application->doRunCommand()                                                            
           #16 /var/www/html/vendor/symfony/console/Application.php(167): Symfony\Component\Console\Application->doRun()    
           #17 /var/www/html/vendor/drush/drush/src/Runtime/Runtime.php(110):                                               
           Symfony\Component\Console\Application->run()                                                                     
           #18 /var/www/html/vendor/drush/drush/src/Runtime/Runtime.php(40): Drush\Runtime\Runtime->doRun()                 
           #19 /var/www/html/vendor/drush/drush/drush.php(139): Drush\Runtime\Runtime->run()                                
           #20 /var/www/html/vendor/drush/drush/drush(4): require('...')                                                    
           #21 /var/www/html/vendor/bin/drush(119): include('...')                                                          
           #22 {main}.                                                                                                      
           Error: Call to a member function getTimestamp() on null in                                                       
           /var/www/html/web/core/modules/serialization/src/Normalizer/TimestampNormalizer.php on line 39 #0                
           /var/www/html/web/modules/contrib/smart_date/src/Normalizer/SmartDateNormalizer.php(40):                         
           Drupal\serialization\Normalizer\TimestampNormalizer->denormalize()                                               
           #1 /var/www/html/vendor/symfony/serializer/Serializer.php(238):                                                  
           Drupal\smart_date\Normalizer\SmartDateNormalizer->denormalize()                                                  
           #2 /var/www/html/web/modules/contrib/smart_date/src/Normalizer/SmartDateItemNormalizer.php(45):                  
           Symfony\Component\Serializer\Serializer->denormalize()                                                           
           #3 /var/www/html/web/core/modules/serialization/src/Normalizer/FieldItemNormalizer.php(33):                      
           Drupal\smart_date\Normalizer\SmartDateItemNormalizer->constructValue()                                           
           #4 /var/www/html/vendor/symfony/serializer/Serializer.php(238):                                                  
           Drupal\serialization\Normalizer\FieldItemNormalizer->denormalize()                                               
           #5 /var/www/html/web/core/modules/serialization/src/Normalizer/FieldNormalizer.php(47):                          
           Symfony\Component\Serializer\Serializer->denormalize()                                                           
           #6 /var/www/html/vendor/symfony/serializer/Serializer.php(238):                                                  
           Drupal\serialization\Normalizer\FieldNormalizer->denormalize()                                                   
           #7 /var/www/html/web/core/modules/serialization/src/Normalizer/FieldableEntityNormalizerTrait.php(152):          
           Symfony\Component\Serializer\Serializer->denormalize()                                                           
           #8 /var/www/html/web/core/modules/serialization/src/Normalizer/EntityNormalizer.php(59):                         
           Drupal\serialization\Normalizer\EntityNormalizer->denormalizeFieldData()                                         
           #9 /var/www/html/vendor/symfony/serializer/Serializer.php(238):                                                  
           Drupal\serialization\Normalizer\EntityNormalizer->denormalize()                                                  
           #10 /var/www/html/web/modules/contrib/tome/modules/tome_sync/src/Importer.php(272):                              
           Symfony\Component\Serializer\Serializer->denormalize()                                                           
           #11 /var/www/html/web/modules/contrib/tome/modules/tome_sync/src/Importer.php(215):                              
           Drupal\tome_sync\Importer->loadEntityFromStorage()                                                               
           #12 /var/www/html/web/modules/contrib/tome/modules/tome_sync/src/Commands/ImportContentCommand.php(34):          
           Drupal\tome_sync\Importer->importContent()                                                                       
           #13 /var/www/html/vendor/symfony/console/Command/Command.php(279):                                               
           Drupal\tome_sync\Commands\ImportContentCommand->execute()                                                        
           #14 /var/www/html/vendor/symfony/console/Application.php(1047):                                                  
           Symfony\Component\Console\Command\Command->run()                                                                 
           #15 /var/www/html/vendor/symfony/console/Application.php(316):                                                   
           Symfony\Component\Console\Application->doRunCommand()                                                            
           #16 /var/www/html/vendor/symfony/console/Application.php(167): Symfony\Component\Console\Application->doRun()    
           #17 /var/www/html/vendor/drush/drush/src/Runtime/Runtime.php(110):                                               
           Symfony\Component\Console\Application->run()                                                                     
           #18 /var/www/html/vendor/drush/drush/src/Runtime/Runtime.php(40): Drush\Runtime\Runtime->doRun()                 
           #19 /var/www/html/vendor/drush/drush/drush.php(139): Drush\Runtime\Runtime->run()                                
           #20 /var/www/html/vendor/drush/drush/drush(4): require('...')                                                    
           #21 /var/www/html/vendor/bin/drush(119): include('...')                                                          
           #22 {main}                                                                                                       
            [warning] Drush command terminated abnormally.                                                                  
                                                                                                                            
                                                                                                                            
                                                                                                                            
  Error Output:                                                                                                             
  ================

If using tome:import:

brian@drupal-foundry-web:/var/www/html$ drush tome:import -y

                                                                                                                        
 [ERROR] Errors encountered when deleting content:                                                                      
                                                                                                                        

                                                                                                                        
 [ERROR] Error when running "'/var/www/html/vendor/bin/drush' 'tome:delete-content'                                     
         'consumer:1,role_watchdog:1,user:0,user:1'":                                                                   
            [warning] Drush command terminated abnormally.

Comment #21

realityloop commented 29 October 2024 at 21:06

Tome maintainer has made a d11 fork here https://git.drupalcode.org/project/tome/-/merge_requests/29

Comment #22

ivnish

he/him

commented 21 November 2024 at 05:03

MR #29 was merged yesterday

Comment #23

ivnish

he/him

commented 28 November 2024 at 05:47

8.x-1.13 was created. Should we close this issue?

Comment #24

project update bot commented 12 January 2025 at 11:44

Issue summary:	View changes
Status:	Needs work	» Needs review

Status	File	Size
new	interdiff-last-bot.6956860.txt	546 bytes
new	tome.1.x-dev.rector.patch	35.04 KB
new	tome.1.x-dev.upgrade_status.post_rector.txt	2.5 KB

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module, even with these changes, this module is not yet compatible with Drupal 11.

Currently Drupal Rector, version 0.20.3, cannot fix all Drupal 11 compatibility problems.

Therefore, these changes did not update the info.yml file for Drupal 11 compatibility.

The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

Debug information

Bot run #11-392907

These packages were used to generate the fixes:

drupal/upgrade_status: 4.3.6
mglaman/phpstan-drupal: 1.3.2
palantirnet/drupal-rector: 0.20.3

Comment #25

larowlan

🇦🇺🏝.au GMT+10

commented 10 July 2026 at 05:19

Issue summary:	View changes
Status:	Needs review	» Fixed

Comment #26

10 July 2026 at 05:19

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Comment #27

24 July 2026 at 05:20

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Automated Drupal 11 compatibility fixes for tome

Problem/Motivation

Proposed resolution

Remaining tasks

Providing feedback

Issue fork tome-3435061

Comments

Drupal 11 Compatibility

Debug information

Drupal 11 Compatibility

Debug information

Drupal 11 Compatibility

Debug information

Drupal 11 Compatibility

Debug information

Related issues