Automated Drupal 11 compatibility fixes for simple_gmap [#3434541]

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 11.

Changes will periodically be added to this issue that remove deprecated API uses. To stop further changes from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD11" tag from the issue to stop the bot from posting updates.

The changes will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

Accept automated changes until this issue is closed
If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD11" tag is left on this issue, new changes will be posted periodically if new deprecation fixes are needed.

As the Drupal Rector project improves and is able to fix more deprecated API uses, the changes posted here will cover more of the deprecated API uses in the module.

Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot changes. The bot will still post new changes then if there is a change in the new generated patch compared to the changes that the bot posted last. Those changes are then up to humans to integrate.
Leave open but stop new automated changes.
If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated changes, remove the "ProjectUpdateBotD11" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated changes again, add back the "ProjectUpdateBotD11" tag.
Close it and don't use it
If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated changes will be posted here.

If the issue is reopened, then new automated changes will be posted.

If you are using another issue(s) to work on Drupal 11 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Using the merge request

Review the merge request and test it.
Thoroughly test the changes. These changes are automatically generated so they haven't been tested manually or automatically.
Provide feedback about how the testing went. If you can improve the merge request, create a new branch and merge request and work from there.

Warning: The 'project-update-bot-only' branch will always be overwritten. Do not work in that branch!

Providing feedback

If there are problems with one of the changes posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.

Comment	File	Size	Author
#15	simple_gmap-D11-compatibility-fixes-3434541-15.patch	2.05 KB	ukor
#6	simple_gmap.3.1.x-dev.rector.patch	2.04 KB	project update bot
#6	interdiff-last-bot.6942684.txt	373 bytes	project update bot
#4	simple_gmap.3.1.x-dev.rector.patch	1.48 KB	project update bot
#4	interdiff-last-bot.6923813.txt	311 bytes	project update bot
#3	simple_gmap.3.1.x-dev.upgrade_status.post_rector.txt	1.79 KB	project update bot
#3	simple_gmap.3.1.x-dev.rector.patch	1.07 KB	project update bot
#3	interdiff-last-bot.6917212.txt	845 bytes	project update bot
#2	simple_gmap.3.1.0.upgrade_status.post_rector.txt	1.85 KB	project update bot
#2	simple_gmap.3.1.0.rector.patch	1.59 KB	project update bot

Issue fork simple_gmap-3434541

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3434541-automated-drupal-11 changes, plain diff MR !7
Check out this branch for the first time

Check out existing branch, if you already have it locally

1 hidden branch

project-update-bot-only

changes, plain diff MR !6

Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

25 March 2024 at 00:25

Project Update Bot created an issue. See original summary.

Comment #2

project update bot commented 25 March 2024 at 00:25

Status:

Active

» Needs review

Status	File	Size
new	simple_gmap.3.1.0.rector.patch	1.59 KB
new	simple_gmap.3.1.0.upgrade_status.post_rector.txt	1.85 KB

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module, even with these changes, this module is not yet compatible with Drupal 11.

Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.

Therefore these changes did not update the info.yml file for Drupal 11 compatibility.

The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

Bot run #11-127659

These packages were used to generate the fixes:

drupal/upgrade_status: 4.1.0
mglaman/phpstan-drupal: 1.2.9
palantirnet/drupal-rector: 0.20.1

Comment #3

project update bot commented 4 April 2024 at 20:22

Version:

3.1.0

» 3.1.x-dev

Status	File	Size
new	interdiff-last-bot.6917212.txt	845 bytes
new	simple_gmap.3.1.x-dev.rector.patch	1.07 KB
new	simple_gmap.3.1.x-dev.upgrade_status.post_rector.txt	1.79 KB

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module, even with these changes, this module is not yet compatible with Drupal 11.

Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.

Therefore, these changes did not update the info.yml file for Drupal 11 compatibility.

The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

Debug information

Bot run #11-137198

These packages were used to generate the fixes:

drupal/upgrade_status: 4.1.0
mglaman/phpstan-drupal: 1.2.10
palantirnet/drupal-rector: 0.20.1

Comment #4

project update bot commented 30 May 2024 at 18:52

Status	File	Size
new	interdiff-last-bot.6923813.txt	311 bytes
new	simple_gmap.3.1.x-dev.rector.patch	1.48 KB

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update the info.yml file for Drupal 11 compatibility.

Debug information

Bot run #11-185727

These packages were used to generate the fixes:

drupal/upgrade_status: 4.3.1
mglaman/phpstan-drupal: 1.2.11
palantirnet/drupal-rector: 0.20.1

Comment #5

30 May 2024 at 18:54

Project Update Bot opened merge request !6

Comment #6

project update bot commented 2 June 2024 at 17:55

Status	File	Size
new	interdiff-last-bot.6942684.txt	373 bytes
new	simple_gmap.3.1.x-dev.rector.patch	2.04 KB

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update the info.yml file for Drupal 11 compatibility.

Debug information

Bot run #11-188815

These packages were used to generate the fixes:

drupal/upgrade_status: 4.3.2
mglaman/phpstan-drupal: 1.2.11
palantirnet/drupal-rector: 0.20.2

Comment #7

17 July 2024 at 12:29

ankitv18 opened merge request !7

Comment #8

17 July 2024 at 12:32

ankitv18 made their first commit to this issue’s fork.

Comment #9

17 July 2024 at 12:57

ankitv18 changed the visibility of the branch project-update-bot-only to hidden.

Comment #10

ankitv18 commented 17 July 2024 at 12:58

Issue summary:

View changes

Please review MR!7

Comment #11

vishalkhode commented 22 July 2024 at 11:43

Status:

Needs review

» Reviewed & tested by the community

Reviewed changes, looks good. Hence, RTBC.

Comment #12

8 August 2024 at 12:03

deepakkm made their first commit to this issue’s fork.

Comment #13

12 August 2024 at 13:40

chandu7929 made their first commit to this issue’s fork.

Comment #14

chandu7929 commented 12 August 2024 at 14:16

I can see some of the commits are missing from 3.1.x, when I tried rebase this with 3.0.x(I don't know what was the purpose to skip that commit)

Comment #15

ukor commented 28 September 2024 at 07:59

Status	File	Size
new	simple_gmap-D11-compatibility-fixes-3434541-15.patch	2.05 KB

Version simple_gmap 3.1.0
Updated patch simple_gmap.3.1.x-dev.rector.patch

Comment #16

vipin.mittal18

He/Him

English

Greater Noida, India

commented 18 October 2024 at 05:15

Hello @martin107,

I hope you’re doing well! I’m reaching out to ask about the release plans for this module with Drupal 11 compatibility. Any updates on the timeline would be greatly appreciated. Thanks!

Comment #17

vipin.mittal18

He/Him

English

Greater Noida, India

commented 18 November 2024 at 17:18

Hello Martin,

It would be greatly appreciated if you could find some time to release a Drupal 11 compatible version of simple_gmap so that the community can upgrade to the most recent version of Drupal. Thanks!

Comment #18

manishvaity commented 2 December 2024 at 06:53

MR!7 Makes this module compatible with Drupal 11. Functionality is working as expected.

RTBC +1

Comment #19

joseph.olstad

French

commented 31 December 2024 at 18:11

I have send a message to Martin Frances (the sole unique and current maintainer/owner of this project) in an attempt to get his attention. I also sent a message in slack to his two mentors (yesct and dawehner).

Hopefully this issue gets resolved promptly!

Thank you!

Comment #20

joseph.olstad

French

commented 8 January 2025 at 15:22

Parent issue:

» #3498022: drupal/simple_gmap

I have invoked the PUWG process , as the current maintainer is not reachable/ unresponsive.

Comment #21

22 January 2025 at 20:20

joseph.olstad committed dd07cb58 on 3.1.x authored by ankitv18

Issue #3434541 by ankitv18, chandu7929, deepakkm, ukor: Drupal 11...

Comment #22

joseph.olstad

French

commented 22 January 2025 at 20:20

Status:

Reviewed & tested by the community

» Fixed

Comment #23

joseph.olstad

French

commented 22 January 2025 at 20:28

https://www.drupal.org/project/simple_gmap/releases/3.1.1

Comment #24

ankitv18 commented 23 January 2025 at 07:38

Hi @joseph.olstad,
Thanks for merging this issue and making this module D11 compatible.
By the I guess you missed to give credits to the contributors :)

Comment #25

joseph.olstad

French

commented 23 January 2025 at 17:02

commit has "by ankitv18, chandu7929, deepakkm, ukor:"

Now also updated the d.o issue for crediting.

Comment #26

23 January 2025 at 17:05

joseph.olstad committed dd07cb58 on 4.0.x authored by ankitv18

Issue #3434541 by ankitv18, chandu7929, deepakkm, ukor: Drupal 11...

Comment #27

6 February 2025 at 17:09

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Automated Drupal 11 compatibility fixes for simple_gmap

Problem/Motivation

Proposed resolution

Remaining tasks

Providing feedback

Issue fork simple_gmap-3434541

Comments

Drupal 11 Compatibility

Debug information

Drupal 11 Compatibility

Debug information

Drupal 11 Compatibility

Debug information

Drupal 11 Compatibility

Debug information

Parent issue

Child issues

Referenced by