Problem/Motivation
Hello project maintainers,
This is an automated issue to help make this module compatible with Drupal 11.
Changes will periodically be added to this issue that remove deprecated API uses. To stop further changes from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD11" tag from the issue to stop the bot from posting updates.
The changes will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.
Proposed resolution
You have a few options for how to use this issue:
- Accept automated changes until this issue is closed
If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD11" tag is left on this issue, new changes will be posted periodically if new deprecation fixes are needed.
As the Drupal Rector project improves and is able to fix more deprecated API uses, the changes posted here will cover more of the deprecated API uses in the module.
Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot changes. The bot will still post new changes then if there is a change in the new generated patch compared to the changes that the bot posted last. Those changes are then up to humans to integrate.
- Leave open but stop new automated changes.
If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated changes, remove the "ProjectUpdateBotD11" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated changes again, add back the "ProjectUpdateBotD11" tag.
- Close it and don't use it
If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated changes will be posted here.
If the issue is reopened, then new automated changes will be posted.
If you are using another issue(s) to work on Drupal 11 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.
Remaining tasks
Using the patches
- Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
- Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
- Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.
Using the merge request
- Review the merge request and test it.
- Thoroughly test the changes. These changes are automatically generated so they haven't been tested manually or automatically.
- Provide feedback about how the testing went. If you can improve the merge request, create a new branch and merge request and work from there.
Warning: The 'project-update-bot-only' branch will always be overwritten. Do not work in that branch!
Providing feedback
If there are problems with one of the changes posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.
| Comment | File | Size | Author |
|---|---|---|---|
| #14 | Screenshot 2024-12-03 112611.png | 5.8 KB | jradhak |
| #2 | responsive_favicons.2.0.1.rector.patch | 505 bytes | project update bot |
Issue fork responsive_favicons-3434213
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- project-update-bot-only
changes, plain diff MR !8
- d11-compatibility-d10+-only
changes, plain diff MR !9
Comments
Comment #2
project update bot commentedThis is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update the
info.ymlfile for Drupal 11 compatibility.Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug information
These packages were used to generate the fixes:
Comment #4
grevil commentedAhh, "CORE_PREVIOUS_PHP_MIN" nice one! 👍LGTM! Thanks!EDIT: Whoops wrong issue
Comment #5
grevil commentedComment #6
grevil commentedAll done!
Comment #7
grevil commentedComment #8
grevil commentedComment #10
grevil commentedI created a second MR dropping the Drupal < 10.3 support. The maintainer should decide which one to merge:
MR !8: Dropping Drupal < 10.3 support
MR !9: Backwards compatible with Drupal 9
Comment #11
w01f commentedTested line changes to src/Form/ResponsiveFaviconsAdmin.php and appears to function correctly.
If we are removing backwards compatibility, the 9 and 10 should be removed from the info.yml file.
core_version_requirement: ^11Comment #12
grevil commented@w01f see my comment in https://git.drupalcode.org/project/responsive_favicons/-/merge_requests/8 and comment #10.
Comment #13
pfrenssenI think the version that drops Drupal <10.3 compatibility is much cleaner and will save us the work to remove this B/C layer in the future. If we choose this version we should create a new 3.0 branch.
Comment #14
jradhak commented#MR 8 works with vanilla D10 and also with D11.
Comment #15
jradhak commentedComment #16
robcarrI installed this fork using Composer with
Added to the
repositoriessection of my site's composer.json file (before thecomposer/https://packages.drupal.org/8bit), then installing the patched module usingcomposer require drupal/responsive_favicons:dev-d11-compatibility-d10+-only. Module downloaded and enabledI had the plugin error too when I uploaded, but the suggestion at https://git.drupalcode.org/project/responsive_favicons/-/merge_requests/... gets around this problem. Seems to work well
Comment #17
grevil commentedComment #18
grevil commentedAgreed.
Comment #19
w01f commentedChiming in that this module made my org's D11 wishlist holdout list - https://www.timbers.dev/article/our-drupal-11-waiting-wishlist-getting-s....
It has over 10k registered sites, so it's fairly well used. Do you need additional support/maintainers to get work on getting a D11-compatible version ready? After reading through the related open issues, it sounds like the plan is to release a completely new major version to slim the codebase down while supporting all the new realfavicon.net functionality/updates?
Comment #21
grevil commentedHiding MR!8 as I agree with @pfrenssen, that we should focus on the Drupal >= 10.3 approach in MR!9 instead (of course the maintainer should decide in the end). https://git.drupalcode.org/project/responsive_favicons/-/merge_requests/... still needs to get resolved, before this can go back to NR, again
Comment #23
wiifmHey all,
Apologies for being AWOL. Drupal contrib development is not top of my pile anymore. I am happy to promote a co-maintainer.
I had a look at the MR, cloned it on a fresh D10 site, and had a look at the MR comments. I have addressed the file extension issue.
Please take a look.
Also happy to drop D9 support, as this is EOL (they can always pin to an older version).
Comment #26
mably commented@wiifm we are using this module on several of our websites.
Happy to help as a co-maintainer if needed.
I would probably create a
3.xdev branch and push MR 9 to it.And then push a fix for this issue: #3488978: Reflect the changes made on https://realfavicongenerator.net
Comment #27
w01f commented+1 for mably as a new co-maintainer and a 3.x branch
Comment #29
mably commentedMerged into new 3.x dev branch.
Comment #30
mably commentedVersion 3.0.0-alpha1 released!
Comment #31
pfrenssenGreat news, thanks a lot!