Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 11.

Changes will periodically be added to this issue that remove deprecated API uses. To stop further changes from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD11" tag from the issue to stop the bot from posting updates.

The changes will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated changes until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD11" tag is left on this issue, new changes will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the changes posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot changes. The bot will still post new changes then if there is a change in the new generated patch compared to the changes that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated changes.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated changes, remove the "ProjectUpdateBotD11" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated changes again, add back the "ProjectUpdateBotD11" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated changes will be posted here.

    If the issue is reopened, then new automated changes will be posted.

    If you are using another issue(s) to work on Drupal 11 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Using the merge request

  1. Review the merge request and test it.
  2. Thoroughly test the changes. These changes are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the merge request, create a new branch and merge request and work from there.

Warning: The 'project-update-bot-only' branch will always be overwritten. Do not work in that branch!

Providing feedback

If there are problems with one of the changes posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.

CommentFileSizeAuthor
#17 r4032login.2.2.x-dev.rector.patch422 bytesproject update bot
#17 interdiff-last-bot.6950419.txt8.69 KBproject update bot
#14 r4032login-settings-error.png62.09 KBmitsuko
#3 r4032login.2.2.x-dev.rector.patch9.83 KBproject update bot
#3 interdiff-last-bot.6916694.txt3.62 KBproject update bot
#2 r4032login.2.2.1.rector.patch4.71 KBproject update bot

Issue fork r4032login-3434086

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Project Update Bot created an issue. See original summary.

project update bot’s picture

project update bot commented
Status: Active » Needs review
StatusFileSize
new r4032login.2.2.1.rector.patch4.71 KB

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update the info.yml file for Drupal 11 compatibility.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

Bot run #11-127659

These packages were used to generate the fixes:

  1. drupal/upgrade_status: 4.1.0
  2. mglaman/phpstan-drupal: 1.2.9
  3. palantirnet/drupal-rector: 0.20.1
project update bot’s picture

project update bot commented
Version: 2.2.1 » 2.2.x-dev
StatusFileSize
new interdiff-last-bot.6916694.txt3.62 KB
new r4032login.2.2.x-dev.rector.patch9.83 KB

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update the info.yml file for Drupal 11 compatibility.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

Bot run #11-199781

These packages were used to generate the fixes:

  1. drupal/upgrade_status: 4.3.2
  2. mglaman/phpstan-drupal: 1.2.11
  3. palantirnet/drupal-rector: 0.20.3

Project Update Bot opened merge request !17

Status: Needs review » Needs work

The last submitted patch, 3: r4032login.2.2.x-dev.rector.patch, failed testing. View results

samit.310@gmail.com made their first commit to this issue’s fork.

samit.310@gmail.com opened merge request !20

samit.310@gmail.com changed the visibility of the branch project-update-bot-only to hidden.

samitk’s picture

samitk commented
Issue summary: View changes
Status: Needs work » Needs review
samitk’s picture

samitk commented

The Drupal 11 compatibility fixes has been done. Please review the changes.

Thanks
Samit K.

benstallings’s picture

benstallings commented
Status: Needs review » Reviewed & tested by the community

I was able to install & enable this in Drupal 11. Thanks!

aaronbauman’s picture

aaronbauman
he/him
commented

worked for me.

RTBC+1

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented

We'd really like to add this module to Drupal CMS (#3472947: [PP-1] Add Redirect 403 to User Login module to base recipe) but we're waiting for this issue to be committed first. :)

Hopefully that sweetens the pot?

mitsuko’s picture

mitsuko commented
StatusFileSize
new r4032login-settings-error.png62.09 KB

The module is functional with the patch above but the config tabs "anonymous" and "Authenticated Behavior" give the following error :

ArgumentCountError: Too few arguments to function Drupal\Core\Form\ConfigFormBase::__construct(), 1 passed in /var/www/html/web/modules/contrib/r4032login/src/Form/AnonymousSettingsForm.php on line 35 and exactly 2 expected in Drupal\Core\Form\ConfigFormBase->__construct() (line 43 of core/lib/Drupal/Core/Form/ConfigFormBase.php).

samitk’s picture

samitk commented

Hi @mitsuko,

The issue you mentioned mentions fixed with MR 20,

Use this MR and check. I hope you issue should be resolved. Please don't hesitate to let us know if the problem will remain.

Thanks
Samit K.

mitsuko’s picture

mitsuko commented

Hi Samit

Thanks for pointing out this info.
You're totally right, the problem is fixed with MR 20 !

Sorry for missing out

project update bot’s picture

project update bot commented
Issue summary: View changes
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new interdiff-last-bot.6950419.txt8.69 KB
new r4032login.2.2.x-dev.rector.patch422 bytes

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update the info.yml file for Drupal 11 compatibility.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

Bot run #11-321467

These packages were used to generate the fixes:

  1. drupal/upgrade_status: 4.3.6
  2. mglaman/phpstan-drupal: 1.3.1
  3. palantirnet/drupal-rector: 0.20.3

somersoft made their first commit to this issue’s fork.

mark_fullmer made their first commit to this issue’s fork.

mark_fullmer’s picture

mark_fullmer
he/him
Primary language English
Location Tucson
commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

There were some deprecation notices in running PHPUnit, as well as the new, super minor code syntax alpha-case ordering requirement (https://www.drupal.org/node/3439320). I typically would want to leave code syntax out of a Drupal 11 compatibility issue commit, but since this change was separate from the functional code itself, I went ahead and included that change. Tests now all pass, so marking as RTBC.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented

Hi,

+1 for a merge and new release for D11 compatibility.

heddn’s picture

heddn
Primary language English
Location Illinois
commented

RTBC++

w01f’s picture

w01f commented

LGTM, tested on Drupal 11.1

ivnish’s picture

ivnish
he/him
commented

Pinged @markdorison in slack 9 January 2025

dieterholvoet’s picture

dieterholvoet commented

If we just get rid of the __construct() methods in the form classes and do all instantiating in the create() method, we won't have this kind of issue again and we can keep the module backwards compatible with Drupal 9. I'll fix that, do a last round of testing and merge it.

dieterholvoet’s picture

dieterholvoet commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.