Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 11.

Changes will periodically be added to this issue that remove deprecated API uses. To stop further changes from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD11" tag from the issue to stop the bot from posting updates.

The changes will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated changes until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD11" tag is left on this issue, new changes will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the changes posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot changes. The bot will still post new changes then if there is a change in the new generated patch compared to the changes that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated changes.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated changes, remove the "ProjectUpdateBotD11" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated changes again, add back the "ProjectUpdateBotD11" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated changes will be posted here.

    If the issue is reopened, then new automated changes will be posted.

    If you are using another issue(s) to work on Drupal 11 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Using the merge request

  1. Review the merge request and test it.
  2. Thoroughly test the changes. These changes are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the merge request, create a new branch and merge request and work from there.

Warning: The 'project-update-bot-only' branch will always be overwritten. Do not work in that branch!

Providing feedback

If there are problems with one of the changes posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.

CommentFileSizeAuthor
#4 monitoring.1.x-dev.upgrade_status.post_rector.txt20.81 KBproject update bot
#4 monitoring.1.x-dev.rector.patch6.28 KBproject update bot
#4 interdiff-last-bot.6916000.txt4.7 KBproject update bot
#2 monitoring.8.x-1.14.upgrade_status.post_rector.txt7.79 KBproject update bot
#2 monitoring.8.x-1.14.rector.patch6.29 KBproject update bot

Issue fork monitoring-3433496

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Project Update Bot created an issue. See original summary.

project update bot’s picture

project update bot commented
Status: Active » Needs review
StatusFileSize
new monitoring.8.x-1.14.rector.patch6.29 KB
new monitoring.8.x-1.14.upgrade_status.post_rector.txt7.79 KB

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module, even with these changes, this module is not yet compatible with Drupal 11.

Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.

Therefore these changes did not update the info.yml file for Drupal 11 compatibility.

The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

Bot run #11-127659

These packages were used to generate the fixes:

  1. drupal/upgrade_status: 4.1.0
  2. mglaman/phpstan-drupal: 1.2.9
  3. palantirnet/drupal-rector: 0.20.1

Project Update Bot opened merge request !13

project update bot’s picture

project update bot commented
Version: 8.x-1.14 » 8.x-1.x-dev
StatusFileSize
new interdiff-last-bot.6916000.txt4.7 KB
new monitoring.1.x-dev.rector.patch6.28 KB
new monitoring.1.x-dev.upgrade_status.post_rector.txt20.81 KB

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module, even with these changes, this module is not yet compatible with Drupal 11.

Currently Drupal Rector, version 0.20.2, cannot fix all Drupal 11 compatibility problems.

Therefore, these changes did not update the info.yml file for Drupal 11 compatibility.

The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

Bot run #11-188815

These packages were used to generate the fixes:

  1. drupal/upgrade_status: 4.3.2
  2. mglaman/phpstan-drupal: 1.2.11
  3. palantirnet/drupal-rector: 0.20.2

Project Update Bot opened merge request !15

acbramley made their first commit to this issue’s fork.

acbramley changed the visibility of the branch project-update-bot-only to hidden.

acbramley opened merge request !18

acbramley’s picture

acbramley commented
Issue summary: View changes
Status: Needs review » Postponed

Blocked on https://www.drupal.org/project/past D11 compat I believe.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

try lenient + sed for the .info.yml change, like in entity_browser: https://git.drupalcode.org/project/entity_browser/-/blob/8.x-2.x/.gitlab...

acbramley’s picture

acbramley commented
Status: Postponed » Needs review
ankitv18’s picture

ankitv18 commented
Status: Needs review » Needs work

There are few of the changes required within MR!18

  1. Like sub-modules info.yml missing D11 support
  2. Tests of sub-modules having public as scope property for module list.
  3. 131 Call to deprecated function format_size():
    in drupal:10.2.0 and is removed from drupal:11.0.0. Use
    \Drupal\Core\StringTranslation\ByteSizeMarkup::create($size,
    $langcode)
berdir’s picture

berdir
Primary language German
Location Switzerland
commented

Plus the usual default views key that needs to be removed that causes most test fails right now.

ankitv18’s picture

ankitv18 commented

@berdir Need one confirmation before fixing below issue:

 Call to deprecated function format_size():                      
         in drupal:10.2.0 and is removed from drupal:11.0.0. Use         
           \Drupal\Core\StringTranslation\ByteSizeMarkup::create($size,  
         $langcode)                                                      
           instead.

As previous major pipeline is failing due to most of the required modules are already dropped the support of D9.

Can we also drop the support of D9 and provide minimum support of D10.2 so that we can avoid using of deprecationHelper or version_compare?

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

Yes, 10.2 is fine.

ankitv18’s picture

ankitv18 commented
Status: Needs work » Needs review

Moving into review now

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Needs work

There's a php deprecation about an undefined property, that's a PHP 8.3 thing that needs to be fixed too. Plus the comment on commerce info files. not sure what the disk error is about, will need to be investigated.

ankitv18’s picture

ankitv18 commented

For below issue I need to debug on my local might be these properties is eliminated from drupal core

 /builds/issue/monitoring-3433496/src/Plugin/monitoring/SensorPlugin/DatabaseDiskUsagePlugin.php:159
    Undefined property: stdClass::$table_name

cc: @berdir @acbramley

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

@berdir It is catching up the submodules but I guess those modules which is specifically mentioned in the static $modules = []; and any of those modules in case missing from info.yml or composer.json require/require-dev section aren't covered with before_script.

No, it's not catching subfolders. Not without the globstar stuff being enabled: https://www.linuxjournal.com/content/globstar-new-bash-globbing-option. We need to use find.

Neither $modules definitions nor require-dev has anything to do with this. require-dev would fail on the composer step, $modules would complain about missing modules. It specifically complains about non-compatible, which is what the sed is trying to fix but doesn't find all files to replace.

Unsure why the undefined property error happens, looks like the query somehow doesn't return what we expect. could be a weird side effect of running this on the system database on CI, so you likely can't reproduce that locally.

  • berdir committed 42dbee3e on 8.x-1.x authored by acbramley 
    Issue #3433496 by berdir, ankitv18, acbramley: Automated Drupal 11...
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Fixed

Merging with the following additional changes:

* allowing commerce 3.x, no more patching required then for that
* remove simplenews dev dependency, we have no simplenews tests, not sure why that was still there
* fixed all tests, some were real issues, like the ajax changes and the config value sensor issues,

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.