Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 11.

Changes will periodically be added to this issue that remove deprecated API uses. To stop further changes from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD11" tag from the issue to stop the bot from posting updates.

The changes will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated changes until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD11" tag is left on this issue, new changes will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the changes posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot changes. The bot will still post new changes then if there is a change in the new generated patch compared to the changes that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated changes.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated changes, remove the "ProjectUpdateBotD11" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated changes again, add back the "ProjectUpdateBotD11" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated changes will be posted here.

    If the issue is reopened, then new automated changes will be posted.

    If you are using another issue(s) to work on Drupal 11 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Using the merge request

  1. Review the merge request and test it.
  2. Thoroughly test the changes. These changes are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the merge request, create a new branch and merge request and work from there.

Warning: The 'project-update-bot-only' branch will always be overwritten. Do not work in that branch!

Providing feedback

If there are problems with one of the changes posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.

CommentFileSizeAuthor
#2 metatag.2.0.0.upgrade_status.post_rector.txt21.61 KBproject update bot
#2 metatag.2.0.0.rector.patch1013 bytesproject update bot

Issue fork metatag-3433376

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Project Update Bot created an issue. See original summary.

project update bot’s picture

project update bot commented
Status: Active » Needs review
StatusFileSize
new metatag.2.0.0.rector.patch1013 bytes
new metatag.2.0.0.upgrade_status.post_rector.txt21.61 KB

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module, even with these changes, this module is not yet compatible with Drupal 11.

Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.

Therefore these changes did not update the info.yml file for Drupal 11 compatibility.

The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

Bot run #11-127659

These packages were used to generate the fixes:

  1. drupal/upgrade_status: 4.1.0
  2. mglaman/phpstan-drupal: 1.2.9
  3. palantirnet/drupal-rector: 0.20.1

Project Update Bot opened merge request !108

naveenvalecha’s picture

naveenvalecha
He/Him
commented
Version: 2.0.0 » 2.0.x-dev
Issue summary: View changes
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Needs work
Related issues: +#3447058: Update info files for Drupal 11

I committed the info file changes separately so this can be left open for actual API fixes. Thank you.

ankitv18 made their first commit to this issue’s fork.

ankitv18 opened merge request !113

chandu7929 changed the visibility of the branch project-update-bot-only to hidden.

jrglasgow made their first commit to this issue’s fork.

jrglasgow’s picture

jrglasgow commented
Status: Needs work » Needs review

The only outstanding PHP Stan issue I am seeing is

sites/default/modules/metatag/metatag_views/src/Form/MetatagViewsTranslationForm.php:173 The 'config_translation/drupal.config_translation.admin' library is not defined because the defining extension is not installed. Cannot decide if it is deprecated or not.

So I have added a check to see if he module is enabled before adding the library. I also rebased.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: » #3466000: Plan for Metatag 2.0.3
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Priority: Normal » Major

Bumping priority on this - it should have been included in the last release but I accidentally overlooked it.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
damienmckenna’s picture

damienmckenna
Location TN, USA
commented

Everything is working, except for a test that checks the page title output. I need to dig into it further, to compare what is happening in the 2.0.x branch vs what is happening in the issue fork as it's not behaving the way I expect.

murilohp made their first commit to this issue’s fork.

murilohp’s picture

murilohp commented

Hey @damienmckenna, I was taking a look at the code in order to debug it and find what's the problem with the test, that's why I did some commits(sorry for the noise by the way, just trying to test it correctly).

Apparently the issue relies on the metatag/src/Plugin/Field/FieldType/MetatagFieldItem.php file, this commit added the change, the problem is actually to replace the $this->value by the $this->getValue(), the getValue function will load all the properties from the propertyDefinitions method(in this case it's just the value, and it returns an array with the following structure:

array:1 [▼
  "value" => "{"title":"[node:title] | [site:name]","description":"[node:summary]","canonical_url":"[node:url]"}"
]

If you take a look at the rest of the code, the code wasn't expecting an array where the key is the property and the value is the metatags. After I change the code, I was able to properly see the tests passing. But I saw some other tests failing, that's why I've done some rollbacks, IDK if all the tests were related to the changes I made, but I don't want to increase the work here, so I just rolled back to the way it was before I changed and I think this explanation might help you to move this forward.

murilohp’s picture

murilohp commented

Just added a new commit and right now it seems the tests all passed, I tried to keep the original idea from metatagFieldItem class by using the getValue and setValue, the setValue expects an array of key => value, so I changed it

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

Amazing work, thank you murilohp!

The remaining issue is this error on the last-minor test run:

PHP Fatal error: Cannot make non static method Drupal\Tests\migrate\Kernel\MigrateSourceTestBase::providerSource() static in class Drupal\Tests\metatag\Kernel\Plugin\migrate\source\d7\MetatagFieldInstanceTest in /builds/issue/metatag-3433376/tests/src/Kernel/Plugin/migrate/source/d7/MetatagFieldInstanceTest.php on line 81

I haven't looked into it yet.

murilohp’s picture

murilohp commented

I was testing locally here, and I wasn't able to reproduce the issue, I found out the function was removed and according to the #3437129: Remove Drupal\Tests\migrate\Kernel\MigrateSourceTestBase::providerSource(), the method was removed from the code, but still expected to be static, the way the method was declared is apparently right, so IDK how to fix it, it would be nice to have some help here to fix this issue.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Assigned: Unassigned » damienmckenna
Status: Needs review » Needs work
Related issues: +#3437129: Remove Drupal\Tests\migrate\Kernel\MigrateSourceTestBase::providerSource()

The providerSource() change means we can't have the tests run against 10.2 anymore, though the rest of the codebase should be compatible. I guess that will have to be a limitation we deal with, and we'll have to disable OPT_IN_TEST_PREVIOUS_MINOR.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Related issues: +#3484975: Resolve phpcs issues

I've changed it so that phpcs tests can fail, will deal with that later: #3484975: Resolve phpcs issues

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

The v2 upgrades fail because the d9 fixtures file was removed. That makes sense.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Reviewed & tested by the community
damienmckenna’s picture

damienmckenna
Location TN, USA
commented

Ok.. so at some point today the default build changed from 10.3 to 11.0. I'll do a separate issue to update the tests to also test 10.3, but otherwise this is ready to go.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Reviewed & tested by the community » Fixed

Committed. Thank you everyone for digging through this.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Assigned: damienmckenna » Unassigned

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.