Problem/Motivation

In #3427741: Notify downstream users that ContainerAware is going away we deprecated support for Symfony's ContainerAwareInterface and ContainerAwareTrait as they are removed from Symfony 7.

This issue exists to finally remove that support in Drupal 11.

Steps to reproduce

Proposed resolution

Commit these issues first:

#3416357: Convert QueueFactory to use a service locator

Remove all remaining references to ContainerAwareInterface.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3431362

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

longwave created an issue. See original summary.

spokje’s picture

spokje
Primary language Dutch
commented
Title: [PP-2] Remove support for ContainerAwareInterface » [PP-1] Remove support for ContainerAwareInterface
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

There is also #3397519: [META] Reduce use of ContainerAware classes where possible, how are the two related? :)

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Parent issue: #3394694: [Meta] Symfony 7 compatibility » #3397519: [META] Reduce use of ContainerAware classes where possible
Related issues: +#3394694: [Meta] Symfony 7 compatibility

Reparenting this under the "reduce" meta, which when reduced to zero can be closed as fixed.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Title: [PP-1] Remove support for ContainerAwareInterface » Remove support for ContainerAwareInterface
Status: Postponed » Active

In fact this doesn't need to be postponed, we can remove the remaining support except for LoggerChannelFactory in this issue now.

spokje’s picture

spokje
Primary language Dutch
commented
Assigned: Unassigned » spokje

Spokje opened merge request !7111

spokje’s picture

spokje
Primary language Dutch
commented
Status: Active » Needs review

Five references left for ContainerAwareInterface after this MR.

They're all needed to keep LoggerChannelFactory working for now.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Needs work

One case where we lost test coverage and can replace it with something else, but otherwise this looks good.

spokje’s picture

spokje
Primary language Dutch
commented
Status: Needs work » Needs review

Thanks @longwave, adjusted test.

spokje’s picture

spokje
Primary language Dutch
commented
Issue summary: View changes
spokje’s picture

spokje
Primary language Dutch
commented
Assigned: spokje » Unassigned

Grmbl...

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Reviewed & tested by the community

Thanks, looks great.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed a058be4 and pushed to 11.x. Thanks!

  • alexpott committed a058be43 on 11.x 
    Issue #3431362 by Spokje, longwave: Remove support for...

Spokje closed merge request !7111

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.