Automated Drupal 11 compatibility fixes for eck

MR!50 installs with composer and can be enabled in Drupal 11. Since the release branch also fails testing, I'm going to consider the testing problem to be outside the scope of this ticket.

RTBC from here as well. +1

In my Drupal 10 project, I installed ECK. However, I couldn't install it in Drupal 11 yet because it's not supported.

As a solution, I copied the eck.git section from the composer.lock file in the Drupal 10 project.

json
Copy code
{
"name": "drupal/eck",
"version": "2.0.0",
"source": {
"type": "git",
"url": "https://git.drupalcode.org/project/eck.git",
"reference": "2.0.0"
},
"dist": {
"type": "zip",
"url": "https://ftp.drupal.org/files/projects/eck-2.0.0.zip",
"reference": "2.0.0",
"shasum": "e1969212f4ce209e84d500a45133f0fe1b093795"
},
"require": {
"drupal/core": "^9.4 || ^10"
},
"type": "drupal-module",
"extra": {
"drupal": {
"version": "2.0.0",
"datestamp": "1683908568",
"security-coverage": {
"status": "covered",
"message": "Covered by Drupal's security advisory policy"
}
}
},
"notification-url": "https://packages.drupal.org/8/downloads",
"license": [
"GPL-2.0-or-later"
],
"authors": [
{
"name": "See contributors",
"homepage": "https://www.drupal.org/node/1155832/committers"
},
{
"name": "akalata",
"homepage": "https://www.drupal.org/user/498926"
},
{
"name": "amykhailova",
"homepage": "https://www.drupal.org/user/2892725"
},
{
"name": "Arrow",
"homepage": "https://www.drupal.org/user/423969"
},
{
"name": "DieterHolvoet",
"homepage": "https://www.drupal.org/user/3567222"
},
{
"name": "dpopdan",
"homepage": "https://www.drupal.org/user/2759811"
},
{
"name": "eric.napier",
"homepage": "https://www.drupal.org/user/501688"
},
{
"name": "fmizzell",
"homepage": "https://www.drupal.org/user/1312210"
},
{
"name": "kelly.m.jacobs",
"homepage": "https://www.drupal.org/user/3397374"
},
{
"name": "legolasbo",
"homepage": "https://www.drupal.org/user/2480548"
},
{
"name": "Matroskeen",
"homepage": "https://www.drupal.org/user/3426249"
},
{
"name": "mducharme",
"homepage": "https://www.drupal.org/user/616996"
},
{
"name": "mihai_brb",
"homepage": "https://www.drupal.org/user/2065978"
},
{
"name": "pifagor",
"homepage": "https://www.drupal.org/user/2375692"
},
{
"name": "RobLoach",
"homepage": "https://www.drupal.org/user/61114"
},
{
"name": "wjaspers",
"homepage": "https://www.drupal.org/user/813890"
}
],
"description": "ECK (Entity Construction Kit) allows users to create and administer entity types, bundles and entities from the UI.",
"homepage": "https://www.drupal.org/project/eck",
"support": {
"source": "http://git.drupal.org/project/eck.git",
"issues": "https://www.drupal.org/project/issues/eck"
}
}
For my Drupal 11 project, I took this code and manually added it to the composer.lock file. I updated the "drupal/core": "^9.4 || ^10 || ^11" part. Then, I added "drupal/eck": "^2.0" to the require section of the composer.json file.

I also added patches in the project under eck.patch. After running composer install via the terminal, ECK is now ready.

Fixed issue in Merge request !50 which was raised by dqd . Kindly review the Merge request !53.

#MR53 works with D10 and D11.

We should probably make sure automated tests are passing before committing/releasing this one: #3422726: Fix tests

There doesn't seem to be a good reason to drop support for Drupal 9.4, so I'm adding that back.

#19: There doesn't seem to be a good reason to drop support for Drupal 9.4, so I'm adding that back.

Absolutely right. 200% Agreed. TBH, I was in conflict on this previously already twice, but it was based on a "trend" in many contrib regarding PHP version support in sync with Drupal core. I wondered why so many users wanted me to remove Drupal 9 support on projects I maintain and they convinced me at this time. But this surely affects not all contrib modules.

#13: Sorry, but to be clear for the logs, there haven't been raised any issue but only work has been continued on MR50 in line with update bot and previous contributors and it just got some minor basic adds/changes for ^11 compatibility as a starting point. And functional and procedual changes and updates in the code base should always be rather discussed carefully with the project maintainers anyways. Also, please do not assign update bot issues to yourself.

Thanks @dieterholvoet for finally updating/fixing and merging a carefully written out commit. Do you prefer any existing follow ups to work on with prio for an upcoming release?

I spent the bigger part of the day on ECK, merging issues, fixing the automated test suite and fixing all code style issues in the codebase. The only other issue I want to merge before creating a release is #3362661: EckEntityRouteProvider does not use link templates, but that one needs a rebase. After that, I’m going to do a last round of manual testing and create a new release.