Port HS support for Taxonomy Views to Drupal 6

I don't know if this will be useful or not. I really want to get this module working with drupal 6 views 2.

I updated the module with deadwood and checked the code with the coder module, there are no errors.
I can enable the module (though it still obviously won't work). There are errors on the HS configuration pages. (admin/settings/hierarchical_select/configs)

The first error was about views_load_cache(); I've been trying to find out if this code is deprecated or what. I tried views_load_view(); in place of views_load_cache(); but still got the error.
I commented out views_load_cache(); Then the config page loaded and I was getting errors about

warning: Invalid argument supplied for foreach() in /home/example/public_html/sites/all/modules/hierarchical_select/modules/hs_taxonomy_views.module on line 478.

I'm trying to find out what changes need to be made so the module works with views 2.

Is there any resources related to updating a views1 module to work with views2?

This not yet working so maybe it's not the right approach.

These files should be unzipped into

hierarchical_select/modules

This will probably require a good bit of change to adapt to the Views 2 API. I'm wondering if this would work better as a views filter handler. I'll try to ask merlinofchaos about it, and post back here.

Subscribing! ;)

I've talked to merlinofchaos about this, and he suggested that this would probably work best as a filter handler of some sort.

merlinofchaos: You may be best off creating a new filter
mikey_p: extending views_handler_filter_term_node_tid ?
merlinofchaos: That'd give you more control.
merlinofchaos: I'm not sure if you'd extend or just make your own; whichever works best.

I'm gonna try to look more at how this was handled in D5 before I figure out when filter type to extend or whether or not to write one from scratch. (I'd prefer to extend for obvious reasons).

hi... how is the actual status? :) Can't wait for this great port.

subscribe

Wim, I would love to work on this but I haven't the time at the moment (surely you know how that feels). I did talk to merlinofchaos about this briefly, and his thought was that instead of form_altering the existing taxonomy filter handler, that it would probably be easier and cleaner code wise to write a new filter handler in the style of the existing taxonomy filter, (maybe even extending the taxonomy filter (go views OOP!)).

In some ways this isn't as clean as would be desired, the user would have choose the HS Taxonomy filter, instead of just Taxonomy filter when in fact this is just a display formatter for the existing functionality of the taxonomy filter. However I think the benefits of having your own filter handler vastly outweigh the advantages of keeping the interface semantics simpler for the end user.

Well the short version, is that Views 2 features a nice OO design, with each filter, argument, field, or relationship item having it's code live in a 'handler' and the handlers in Views 2 are classes that extend a few base classes that define some basic methods for each item. For filters it's mainly options forms, exposed forms, and the validation functions that live in the end filters as methods, and in between there are a couple of general purpose handlers that handle the actual query modifications.

For instance, checkout the handler for the Taxonomy filter: http://views.doc.logrus.com/views__handler__filter__term__node__tid_8inc...

and then the it's parent at: http://views.doc.logrus.com/classviews__handler__filter__many__to__one.html

Basically the make your own filter version would involve either building a filter handler like view_handler_filter_term_node_tid that extends view_handler_filter_many_to_one, or a handler that extends views_handler_filter_term_node_tid directly and adds the settings for HS in the options_form methods.

It looks like I'll get the opportunity to work on this issue over the coming weeks, we need this feature for a project that I'm working on two days a week. Can anyone who is actively developing it please get in touch so that we can co-ordinate and avoid duplicating effort please?

I know it's asking a lot but I'd also really appreciate it if anyone who has spent some time looking into this would be brave enough to put a time estimate on it? I have a lot of experience of the Drupal API but none of writing handlers for Views 2. Looks like we've already got some good info in this issue.

Hi Wim, Just to let you know I'll be working on this today. It's a bit difficult to decide what is the best route without just diving in and getting started, so I'm going to look at extending the existing taxonomy filter handler first, specifically views_handler_filter_term_node_tid. If it starts to look like we need to override a lot, I'll drop back and extend views_handler_filter_many_to_one instead. Should I assign this issue to me?

subscribing =)

definitely subscribe, thank you!

Hi,

Subscribing, very interesting!

Greetings,
Martijn

subscribing :-)

subscribing

I've done about a day on this so far and I think I'm about half way there. One question has been thrown up today which I'd appreciate it if people could respond to as I'll be continuing development tomorrow:

Q: Is it desirable to set the hierarchical select element's options in the options box for the views filter? The alternative option is to leave the view filter options alone and have a separate page for setting the hierarchical select configuration options - as is the case in the Drupal 5 version.

Hi Wim, I think you're right it would cramp the views interface to have the HS options there. I will release a demo later today hopefully, it's not quite at that stage yet.

Unfortunately I'm not at DrupalCon :-( I'm based in the UK and just couldn't take the time off for a trip to the US. I'm going to be starting a Drupal shop in Singapore later this year so lots of work going to preparation for that at the moment too!

subscribing, this is critical

subscribing

subscribing

Hey, I've attached a patch of my work, this is taken from HEAD in the hierarchical_select module directory. Wim is going to review this and sort out a couple of issues in order for it to work correctly so there is no point in anyone else reviewing it at the moment.

Wim, you will see my dirty hack in hierarchical_select.module for the views caching problem, I've have just used a session variable to store the name at the moment but you may have a nicer solution? The remaining issues are in a comment at the top of hs_taxonomy_views.module - I've marked the ones you said you'd have a look at since they are related to the main hierarchical select module. Good luck!

subscribing

subscribing

(sorry for my english)

I don't really know what is the problem! But maybe this will help...

http://drupal.org/node/342992#comment-1430622

Hi all, unfortunately I will not be able to do any more work on this for at least the next 6 weeks. Wim's last comment (#29) contains the most recent version of the patch. It is not working as it stands but a lot of work has been done and there is only really one critical issue remaining.

how can we help? Coding ;) ... or something else? Since I don't know the code it would take me a while to get into this.

subscribing

@WimLeers. 1 million??? what would be more important? ;) ... when do you have more time? Is anybody else working on this right now?

Hi Wim, So very much appreciated you guys are trying! Hopefully in July you got a great brainwave!
Again thanks for trying and considering still building this!

Greetings, Martijn
www.trekking-world.com

Subscribing.

Subscribing.

subscribe

закладка

"закладка" is something like "Subscribing".

Subscribing

Subscribing

5.x-3.0 already has Taxonomy Views implemented.

Subscribing...

Subscribing...

Subscribing...

subscribing

This module has just been released:

http://drupal.org/project/views_filter_pack

It's not Hierarchical Select but it may help some of you who desperately need to improve your views filters. Disclaimer: I have no idea if it works or not.

What about the Taxonomy Super Select module? Seems to work like this one, but with a slightly different twist, presentation/look & feel...

Oi, this module is vital for large scale eCommerce. It seems like i'll have to abandoned my exposed filters entirely and move to an argument driven view that's fed from a static Javascript object. It's not the drupal way, but per the comments above sometimes the drupal way unfortunately involves skilled coders trying to build awesome modules on top of unstable base code.

In my case, nothing would work as good as HS.

+1

As the last relevant posting I can see says that the patch does not work, I'm gonna take it at face value and set this to "needs work".

This is mission critical for a project I want to launch in the not to distant future so I am going to start looking into it. No promises, as I'm not familiar with the code and given the caliber of people who already took a crack at it, I'm not sure how much good I'll be able to do.

Wimleers and/or johngriffin, I'll be on AIM/SKYPE and/or IRC as samtresler or Tresler if you are already working on something or have pearls of wisdom, please ping me.

p.s. NOT assigning it to me till I get a grasp of what is entailed. Cheers.

Talked to WimLeers who thinks he can look at this in the next few weeks so I'm sitting back for a while, crossing my fingers, and offering to test patches.

Cheers

+1

Subscribing...

Ok, I'm new to this module but my first impresion is: WOW!
This is great work what you (all) had done.

@Wim: Hoping your effort on this will be successful!
Thanks in advance!

Wim Leers for president! What do you say, guys?

Thanks for the great effort, your work is a great improvement for the whole Drupal!

I'm getting the following error when using this with the dev version of Hierarchical Select and the version of Hierarchical Select Content Taxonomy from here http://drupal.org/node/342992#comment-1809098. I can't work out what code is at fault. The error didn't happen when I first installed the modules but has happened after I changed some settings, although changing them back to what they were doesn't seem to stop the error;

# warning: Invalid argument supplied for foreach() in /srv/www/htdocs/sites/all/modules/views/includes/handlers.inc on line 680.
# user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ') ) count_alias' at line 6 query: SELECT COUNT(*) FROM (SELECT DISTINCT(node.nid) AS nid, node.title AS node_title FROM node node LEFT JOIN content_field_associated_course_instance node_data_field_associated_course_instance ON node.vid = node_data_field_associated_course_instance.vid LEFT JOIN node node_node_data_field_associated_course_instance ON node_data_field_associated_course_instance.field_associated_course_instance_nid = node_node_data_field_associated_course_instance.nid WHERE (node.type in ('course')) AND () ) count_alias in /srv/www/htdocs/sites/all/modules/views/includes/view.inc on line 729.
# user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ') LIMIT 0, 10' at line 6 query: SELECT DISTINCT(node.nid) AS nid, node.title AS node_title FROM node node LEFT JOIN content_field_associated_course_instance node_data_field_associated_course_instance ON node.vid = node_data_field_associated_course_instance.vid LEFT JOIN node node_node_data_field_associated_course_instance ON node_data_field_associated_course_instance.field_associated_course_instance_nid = node_node_data_field_associated_course_instance.nid WHERE (node.type in ('course')) AND () LIMIT 0, 10 in /srv/www/htdocs/sites/all/modules/views/includes/view.inc on line 755.

Actually I've just realised I am actually using Taxonomy rather than Content Taxonomy!

Hi Wim,

I just wanted to ask do you plan to release a patch for Content Taxonomy Views too in the near future?

Thanks in advance

Hi Wim,

I've restored my database to a backup and it doesn't seem to be happening now. I have the latest HS and the latest released version of Views (do I need the dev version)?

It may have also been to do with me having Content Taxonomy HS installed before (I've since uninstalled this).

Regards,

Ben

Will apply on a copy of the site I'm working on shortly.

Going to test this today.

I would really love to test this patch but I am trying to learn how to apply a patch without doing it manually (i.e. add and delleting the lines of code.) I read this but I am still confused http://drupal.org/node/60179 Any input would be appreciated.

Thanks. I'm trying

Thanks so much going to test now.

After adjustment hs_views, I see:

http://localhost/drupal6.13dev/?q=admin/build/views/hs_config/ViewTest/d...

Fatal error: Call to undefined method stdClass::save() in C:\webserver\Apache2.2\htdocs\drupal6.13dev\sites\all\modules\hierarchical_select\modules\hs_taxonomy_views.module on line 330

Testing on Exisitng View and I now have a box that reads Sort Criteria but it is leaving a message of

Error: handler for term_data > tid doesn't exist!

When I'm created the new filter for views - I see the message:

You don't have Javascript enabled. Hover for more information! But don't worry: you can still use this web site! You have two options:
But JS enable.

But with all these errors, HS works correctly on Views page

@andres_jw -- I get that javascript message occassionally, particularly when using Chrome; it appears to be when the page doesn't fully load correctly or some type of local memory / cache issue, as it's sporadic. (In other words, I have no idea why it shows up sometimes, but it usually ~doesn't~ show up.)

When I do get it, I reload a storm menu item and then drill down to the page I was on again and it usually reloads correctly unless I've got too many other windows open and loading other pages.

Dunno if that's something anyone else is experiencing, but thought it might be worth sharing.

Installed latest hierarchical select (HEAD) applied patch, upgraded to latest stable Views (DRUPAL-6--2-6).

When running update.php for views hierarchical_select also wanted to run update 8, which may be a legacy from when I had this installed before, either way it looks fine "UPDATE {system} SET weight = 16 WHERE name = 'hierarchical_select'"

Back to admin/build/modules enable Hierarchical Select and Hiearchical Select Taxonomy. Enabled cleanly.

Edit the vocabulary in question and check Use the Hierarchical Select form element for this vocabulary.

Navigate to node/add/content-type and the form element appears to work throughout the node add process.

However, after that I go to enable hs_taxonomy_views and get that it is incompatible with the current version of Drupal Core (6.13) so, I can't test the taxonomy_views section yet. I'm about to try on a completely clean version of 6.13 in the event something on my current site is screwing this up.

Please post if I am missing something obvious.

Hrm, strike that, looking at the .info files I see that my version of hs_taxonomy_views.info isn't updated so I see the patch wasn't applied correctly, or perhaps completely. Trying again.

OK! so the patch isn't applying cleanly:

li26-107:/home/web/thenyclife.com/www/sites/all/modules# cvs -z6 -d:pserver:anonymous:anonymous@cvs.drupal.org:/cvs/drupal-contrib co -d hierarchical_select -r HEAD contributions/modules/hierarchical_select

// Output from the checkout removed for brevity:

li26-107:/home/web/thenyclife.com/www/sites/all/modules/hierarchical_select# wget http://drupal.org/files/issues/views-v17.patch
--12:35:39-- http://drupal.org/files/issues/views-v17.patch
=> `views-v17.patch'
Resolving drupal.org... 140.211.166.6
Connecting to drupal.org|140.211.166.6|:80... connected.
HTTP request sent, awaiting response... 200 OK
Length: 66,409 (65K) [text/plain]

100%[=======================================================>] 66,409 200.33K/s

12:35:39 (199.55 KB/s) - `views-v17.patch' saved [66409/66409]

li26-107:/home/web/thenyclife.com/www/sites/all/modules/hierarchical_select# patch -p0 < views-v17.patch
patching file API.txt
Hunk #1 succeeded at 78 (offset 3 lines).
Hunk #2 FAILED at 114.
Hunk #3 succeeded at 184 (offset 7 lines).
Hunk #4 succeeded at 223 (offset 7 lines).
Hunk #5 succeeded at 424 (offset 9 lines).
1 out of 5 hunks FAILED -- saving rejects to file API.txt.rej
patching file README.txt
Hunk #2 FAILED at 168.
1 out of 2 hunks FAILED -- saving rejects to file README.txt.rej
patching file hierarchical_select.js
patching file hierarchical_select.module
Hunk #3 FAILED at 366.
Hunk #6 succeeded at 643 (offset 2 lines).
Hunk #7 succeeded at 765 (offset 2 lines).
Hunk #8 succeeded at 781 (offset 2 lines).
Hunk #9 succeeded at 919 (offset 2 lines).
Hunk #10 succeeded at 1166 (offset 2 lines).
Hunk #11 succeeded at 1227 (offset 2 lines).
Hunk #12 succeeded at 1267 (offset 32 lines).
Hunk #13 succeeded at 1311 (offset 32 lines).
Hunk #14 succeeded at 1559 (offset 32 lines).
Hunk #15 succeeded at 1604 (offset 32 lines).
Hunk #16 succeeded at 1612 (offset 32 lines).
Hunk #17 succeeded at 1684 (offset 33 lines).
Hunk #18 succeeded at 2192 with fuzz 2 (offset 84 lines).
1 out of 18 hunks FAILED -- saving rejects to file hierarchical_select.module.rej
patching file includes/common.inc
Hunk #1 succeeded at 84 with fuzz 2 (offset 43 lines).
Hunk #2 succeeded at 107 (offset -23 lines).
patching file includes/theme.inc
patching file includes/views.js
patching file modules/hs_taxonomy_views.info
patching file modules/hs_taxonomy_views.module
patching file modules/hs_taxonomy_views_handler_filter_term_node_tid.inc
li26-107:/home/web/thenyclife.com/www/sites/all/modules/hierarchical_select#

It looks like only one of the three failures was related to code. Am I patching to the right codebase? this is against HEAD, correct?

Ignoring that error for a moment, I now see in the node creation and edit form the HS form element, but when I attempt to select a taxonomy term I am getting a firefox popup that says "Invalid response from server"

I'm gonna back up and get a totally clean copy of views, HS, and Drupal, and create some dummy data on localhost as opposed to my server. This should tell me if this is related to my install or the patch. I should be able to get to that tomorrow or later today.

Hi Tresler,

Looks like you're applying an old version of the patch which is probably the cause of most of your errors. Wim updated the patch as it was broken against the latest revision of HEAD. See #76 for a link to the new patch.

indeed. Oops.

Ok, *that* patch applies cleanly.

Upon enabling a views filter and hitting the link provided for "configure Hierarchical Select" I get the php error:

Fatal error: Cannot use string offset as an array in /home/web/thenyclife.com/www/includes/form.inc on line 979

However, if I avoid hitting that link and just update the filter I also get the You don't have Javascript enabled error, when I most certainly do. This prevents me from editing the details of a taxonomy filter and it never shows up on the view itself.

Gotta run for now, but will try to be back tomorrow.

Thanks, I will test

Actually, got some more time tonight. Installed on a fresh download this time, new drupal/views/and HS

Enabled only HS, hs taxonomy, hs taxonomy views, views, and vies UI. First step was to create a vocabulary for testing and got this at: http://d6.lcl/admin/content/taxonomy/add/vocabulary

* notice: Undefined index: vid in /home/stresler/www/d6/sites/all/modules/hierarchical_select/modules/hs_taxonomy.module on line 17.
* notice: Trying to get property of non-object in /home/stresler/www/d6/sites/all/modules/hierarchical_select/modules/hs_taxonomy.module on line 65.
* notice: Undefined offset: 0 in /home/stresler/www/d6/sites/all/modules/hierarchical_select/modules/hs_taxonomy.module on line 690.
* notice: Undefined variable: tree in /home/stresler/www/d6/sites/all/modules/hierarchical_select/modules/hs_taxonomy.module on line 707.
* notice: Undefined variable: depth in /home/stresler/www/d6/sites/all/modules/hierarchical_select/modules/hs_taxonomy.module on line 768.
* notice: Undefined offset: 0 in /home/stresler/www/d6/sites/all/modules/hierarchical_select/modules/hs_taxonomy.module on line 690.
* notice: Undefined variable: tree in /home/stresler/www/d6/sites/all/modules/hierarchical_select/modules/hs_taxonomy.module on line 707.
* notice: Undefined variable: depth in /home/stresler/www/d6/sites/all/modules/hierarchical_select/modules/hs_taxonomy.module on line 768.
* notice: Trying to get property of non-object in /home/stresler/www/d6/sites/all/modules/hierarchical_select/modules/hs_taxonomy.module on line 80.
* notice: Undefined index: #config in /home/stresler/www/d6/sites/all/modules/hierarchical_select/includes/common.inc on line 49.
* notice: Undefined index: require_entity in /home/stresler/www/d6/sites/all/modules/hierarchical_select/includes/common.inc on line 172.
* notice: Undefined offset: 0 in /home/stresler/www/d6/sites/all/modules/hierarchical_select/includes/common.inc on line 219.
* notice: Undefined offset: 0 in /home/stresler/www/d6/sites/all/modules/hierarchical_select/includes/common.inc on line 303.
* notice: Undefined index: op in /home/stresler/www/d6/sites/all/modules/hierarchical_select/hierarchical_select.module on line 921.
* notice: Undefined offset: 0 in /home/stresler/www/d6/sites/all/modules/hierarchical_select/modules/hs_taxonomy.module on line 690.
* notice: Undefined variable: tree in /home/stresler/www/d6/sites/all/modules/hierarchical_select/modules/hs_taxonomy.module on line 707.
* notice: Undefined offset: 0 in /home/stresler/www/d6/sites/all/modules/hierarchical_select/modules/hs_taxonomy.module on line 690.
* notice: Undefined variable: tree in /home/stresler/www/d6/sites/all/modules/hierarchical_select/modules/hs_taxonomy.module on line 707.
* notice: Undefined index: require_entity in /home/stresler/www/d6/sites/all/modules/hierarchical_select/hierarchical_select.module on line 1866.
* notice: Undefined property: stdClass::$childinfo in /home/stresler/www/d6/sites/all/modules/hierarchical_select/hierarchical_select.module on line 1046.
* notice: Undefined index: #size in /home/stresler/www/d6/sites/all/modules/hierarchical_select/hierarchical_select.module on line 512.
* notice: Undefined index: #disabled in /home/stresler/www/d6/sites/all/modules/hierarchical_select/hierarchical_select.module on line 659.
* notice: Undefined index: #post in /home/stresler/www/d6/includes/form.inc on line 886.
* notice: Undefined index: #post in /home/stresler/www/d6/includes/form.inc on line 886.
* notice: Undefined index: #post in /home/stresler/www/d6/includes/form.inc on line 886.
* notice: Undefined index: #post in /home/stresler/www/d6/includes/form.inc on line 886.
* notice: Undefined index: #post in /home/stresler/www/d6/includes/form.inc on line 886.
* notice: Undefined index: #post in /home/stresler/www/d6/includes/form.inc on line 886.
* notice: Undefined index: hs_form_build_id in /home/stresler/www/d6/sites/all/modules/hierarchical_select/hierarchical_select.module on line 717.
* notice: Undefined index: class in /home/stresler/www/d6/sites/all/modules/hierarchical_select/includes/theme.inc on line 33.
* notice: Undefined index: #error in /home/stresler/www/d6/sites/all/modules/hierarchical_select/includes/theme.inc on line 43.

Gonna ignore for now and keep testing. To confirm this is with the views-v19.patch applied cleanly.

Ok, you can create the vocabulary, but when you get to adding terms the hierarchical select form item appears on the advanced options for selecting parents and siblings, I don't know if this is intended to show up on the admin forms or not.

When attempting to select parent or sibling terms I get the invalid response from server popup again upon hitting the HS add term button. I then installed devel and emptied the cache, same thing. and rebuilt the menus, same result.

So, I think the current patched version prevents the addition of terms with parents or siblings somehow. (firefox3.0.11/kubuntu), also the same error as above is appearing on all admin/ pages for the new vocabulary.

I used the devel module to generate terms to bypass the above limitation and have 3 vocabularies with children terms to work with.

A) Upon creating a view and adding a filter it appears that I can choose hierarchical select for vocabularies that I haven't enabled "Use hierarchical select" on in the vocabulary settings. This may be intended behaviour, but it seems odd to me. Ignore if irrelevant.

B) The errors from above starting with "notice: Undefined index: 27 in /home/stresler/www/d6/sites/all/modules/hierarchical_select/modules/hs_taxonomy.module on line 700." seem to be prevalent on each page that might use HS, ignoring until further notice. WIll list any others.

C) When adding a filter for a view, if one hits the Configure Hierarchical select Link, it takes you to the configure form. However, if you then hit the Return to views configuration link, you are told that "An invalid vocabulary is selected. Please change it in the options." You can then go to the filter settings and change it, but this seems like odd behaviour, the Return to views config should take you back to where you left off.... if possible.

D) When adding a filter for a view, if one doesn't use the configure HS link, you can choose a vocabulary. Once chosen you have the standard views options for term filters 'is one of', 'is all of', 'is none of'. When selecting 'is all of' you can't multi-select terms using the HS form element. It seems that if HS is going to be implemented here it should be displayed with its "Add term" button. Or just not be displayed here in an admin form.

E) During view creation, I at one point got this:
# notice: Trying to get property of non-object in /home/stresler/www/d6/sites/all/modules/hierarchical_select/modules/hs_taxonomy_views.module on line 534.
# notice: Trying to get property of non-object in /home/stresler/www/d6/sites/all/modules/hierarchical_select/modules/hs_taxonomy_views.module on line 535.
# notice: Trying to get property of non-object in /home/stresler/www/d6/sites/all/modules/hierarchical_select/modules/hs_taxonomy_views.module on line 535.

F) Upon attempting to save a view, I get the following error:

# warning: implode() [function.implode]: Invalid arguments passed in /home/stresler/www/d6/sites/all/modules/views/modules/taxonomy/views_handler_filter_term_node_tid.inc on line 295.
# user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ')' at line 1 query: SELECT * FROM term_data td WHERE td.tid IN () in /home/stresler/www/d6/sites/all/modules/views/modules/taxonomy/views_handler_filter_term_node_tid.inc on line 295.

G) On the view page itself the filters appear, but changing them results in the "Invalid response from server" popup error. Also, it seems add that in teh view config I couldn't set them to be for multiple terms, but in the HS select box on the view, all terms appear.

Hope this actually helps and isn't just too much signal to noise. Please tell me if you have any specific tests you want me to perform, or if you need a hand in some of the easier to grok coding. Thanks for all your hard work!

Just had a quick test...

Looks like I have to save the view first before the HS drop-downs in the views UI can be used.

Steps to reproduce:

1. Create new taxonomy term filter and select Hierarchical select, click Update.

2. If you click "Configure Hierarchical select" link I get 404 not found (URL: admin/build/views/hs_config/SearchRoutes/default/tid ) - intermittent though, seems to work now.

3. All other HS dropdowns don't seem to work until I save the view, showing a JS alert of "Invalid response received from server". Firebug shows: POST http://dev.drupal6/hierarchical_select_json 404 Not Found

...

Filter seems to work perfectly when exposed on an actual page view. I noticed that the dropbox is buggy on the views UI preview though, not filtering correctly and losing it's value when you click apply.

Fantastic work though, I'll do some more testing soon!

Ok. Will be test

Updated to latest patch 21. That solved several of these, so if it isn't re-listed here, assume it is taken care of.

C) Problem: Configure HS link in view filter creation returns you to view page at a different point. This is somewhat minor.

To reproduce:
- install drupal, hs_tax_views, vviews, and devel, and generate nodes and terms with devel
- navigate to /admin/build/views/add and create a new node-type view
- add a Page display
- add a Taxonomy: Term filter to the page display
- Under "Page: Configure extra settings for filter Taxonomy: Term" select Hierarchical Select:
- Click the Configure link that appears.

At this point, you are now configuring for the default display when you were editing the Page display you were attempting to create. If you click return to views configuration on this page, you land back on the views default display config with your filter applied to the Default view AND the Page view. Furthermore, these filters don't have a vocabulary selected on them, as configuration was never completed, you can click back through and add them, but the user would need to know to do that.

It seems this behaviour is the same whenever you configure an HS taxonomy filter for any display (i.e. automatically adding it to the default display.) I would assume that you need to 'override' the default /before/ configuring HS, but not sure about that.

D) Of course you can, but you must enable the dropbox first. The reason is simple: the same settings are applied to the "Select terms from vocabulary " HS instance as to the HS instance on the exposed filters form. Why should the admin be allowed to select multiple terms if the end user can not? And how would that then be presented through HS? If you disagree, convince me of your point of view :)

I see what you are saying, but was very confused for a moment.

Right now, once I have chosen a vocabulary, I have the ability to select "Is all of" without having selected the dropbox option on HS effectively let me choose one option for an operator that implies more than one option. There should probably be some help text, letting the user know they can change that in the HS config
if they want it. Way, way minor, let me know if you want me to open a separate issue for it.

Other than those things. This is totally usable. Thanks again for the time you are spending on this.

It might be good to get another person to reproduce this before Wimleers loosk at it if he is busy, as it is a bit involved. It took me over an hour to get reproduction steps accurate and having someone double check them would be nice.

HS preserves HS config after filter has been removed, AND won't allow alterations to new filters.

Steps to reproduce:
- Install clean Drupal, patched HS Views (views-21.patch), devel, and Views
- Generate 3 Vocabularies with children and 50 nodes.
- Create a View with a page display, path /test
- Add a taxonomy ID filter.
- Set to exposed.
- choose first vocabulary, and HS. hit update.
- Click on settings for the filter and click link to go to HS configuration.
- Enable dropbox, alter Title text ( I used title for ease of testing, other settings are similarly affected). I entered 'blah'. Save the config.
- click the link to take you back to the views config.
- Save the view.
- Check the view at example.com/test
- confirm 'blah' is the text that is listed on example.com/test.
- Edit the view and remove the taxonomy filter.
- clear views cache and drupal cache (just for safe measure.)
-Confirm the filter is gone at example.com/test

At this point that filter AND the HS config should be gone

- Add a taxonomy ID filter to the view.
- Select the *3rd* vocaulary ( could use the first, but using the third just checks that this bug isn't tied to the vocab used originally).
- Select HS, and update the filter.
- Select the filter settings and go to the HS config.
- Enable the dropdown box and enter a different unique string into the Title. 'Foobar'
- save teh config.
-navigate back to the view edit form using the link.
-Save the view.

visit example.com/test
The original text 'Blah' is there instead of 'foobar'.
As near as I can tell, at this point the only way to change the HS settings is to re-create the entire view from the beginning and delete this view.

Can someone else please confirm?

Meanwhile, I found what is wrong with getting back to the views edit page from the HS config page, see 104 C. "tabs" should be "tab" in the url constructed on line 298 of hs_taxonomy_views.module. Such a small fix I didn't roll a patch, Wimleers if you want to remove the 's' on the next one it would be handy.

In regards to 105, this behaviour is explained by HS_taxonomy_views always using the default display, regardless of override settings in the individual display. The interesting part is that this persists after deleting the Default filter and saving the view.

Subscribing.

Can't wait for this... Thanks to all developers.

I tested and it seems to work fine but I did need to go in and resave my current view and then it worked great.

In the zip the function hierarchical_select_common_config_del() is declared twice starting at line 42 in includes/common.inc . No other errors noticed yet once removed though.

With this latest, I get the following fatal error on the page with the exposed hs taxonomy filter in a block:

Fatal error: Call to a member function clone_view() on a non-object in /(...)/sites/all/modules/hierarchical_select/modules/hs_taxonomy_views.module on line 423

This is on an already exisiting site with taxonomy and views.
I configured all settings, and the hs does show up in the preview pane when you add the filter in Views (though it does give the occasional JS invalid response error). However on the view itself I get the following error.

I'll doucle check my steps, but first I'm going to install it on a clean Drupal.

Guys,
Your are doing a great job.
Even that i can`t still use HS on Views exposed taxonomy term i thank you.
When you think there is gonna be an update?

Installed module files from zip, added HS to my view. Then at the preview I get following errors:
* warning: Illegal offset type in /home/crea/workspace/Drupal 6 Development/includes/common.inc on line 1608.
* warning: uasort() [function.uasort]: The argument should be an array in /home/crea/workspace/Drupal 6 Development/includes/common.inc on line 2843.
Also selecting any term in HS widget results in "Received invalid response from the server".

I resaved my view once more (I did it already after I added HS) and previous problem started to show sometimes, not always.

Also, I think I have found a bug. When HS dropbox is set to "reset selection" widget selection seems to be ignored by the view, cause when I press "apply" button during preview, view is ignoring terms added to selection, and widget resets to empty.

Hi Wim,

The HS works on node/$/edit but i cannot make it working on views exposed Taxonomy nor Content taxonomy field.
I just get a large select menu..
I must note that i didn`t use the file attached in this thread but the ones on modules pages.
Should i use these here?

Thanks Wim.

I will wait to be cvs-uped..

#121:
Hi! I has errors like #118 too.
For cleanliness of experiment I try reproduce that on a vanilla Drupal installation.
Firs, I see that results "Received invalid response from the server" if form widget exposed in block.
I cannot tell that have found other errors in pure installation. This consequence much is possible water also sortings in tabular representation. But I think, it is possible to begin with an error in block representation.

...Thanks for fine work. This module is very important for my work.

subscribe

These preview errors are probably connected to #541132: Hierarchical Select breaks with >1 Hierarchical Select form item on the page

thanks for the .zip, works a treat

Hi Wim,

I tried the latest .zip (in#126) but I can't enable;
-Hierarchical Select Book
-Hierarchical Select Content Taxonomy
-Hierarchical Select Content Taxonomy Views

As they are not compatible with version 6.13 of Drupal core. Is this correct or is it something in my settings?
I really would like to give Hierarchical Select Content Taxonomy Views a go.

Cheers

Hi Wim,

I've been playing with the version attached with comment #126 and found the following;

- admin/settings/hierarchical_select/configs

    * warning: array_merge_recursive() [function.array-merge-recursive]: Argument #2 is not an array in C:\xampplite\htdocs\mydomain\sites\all\modules\hierarchical_select\hierarchical_select.admin.inc on line 79.
    * warning: array_merge_recursive() [function.array-merge-recursive]: Argument #1 is not an array in C:\xampplite\htdocs\mydomain\sites\all\modules\hierarchical_select\hierarchical_select.admin.inc on line 79.
    * warning: Invalid argument supplied for foreach() in C:\xampplite\htdocs\mydomain\sites\all\modules\hierarchical_select\hierarchical_select.admin.inc on line 84.

The overview of all Hierarchical Select confirgurations is empty

- Other errors I've encountered are with adding terms to a taxonomy (as user 1)
When I add the same sub-sub-term to multiple sub-terms I get this error;

user warning: Duplicate entry 'category/soort-hulpverlener/verloskundige/overige-hulpverleners/' for key 2 query: INSERT INTO sgz_url_alias (src, dst, language) VALUES ('taxonomy/term/41', 'category/soort-hulpverlener/verloskundige/overige-hulpverleners/oefentherapeut/huisartsenpost/huisarts/fysiotherapeut/eerstelij-0', '') in C:\xampplite\htdocs\mydomain\modules\path\path.module on line 112.

Yet the term is being added to all selected subterms?

- A critical bug is the following;
When in admin/content/taxonomy/2/add/term and trying to add a term of the 3rd level I'm getting strange errors.
For instance I want to add the term sedan to red
car -> red -> sedan

This works, yet the term is also being added to
bicycle -> red -> sedan

Which is rather strange!

- Another critical bug;
I want to add a second term to red called stationwagon
car -> red -> stationwagon
This results in mahem, can't explain but please attached see picture (terms are different the from my explanation above)

No if I click the 'add term' tab from that mahem page I get a whole lot of errors;

    * warning: preg_match() expects parameter 2 to be string, array given in C:\xampplite\htdocs\zoetermeer-gezond\includes\bootstrap.inc on line 771.
    * warning: preg_match() expects parameter 2 to be string, array given in C:\xampplite\htdocs\zoetermeer-gezond\includes\bootstrap.inc on line 771.
    * warning: preg_match() expects parameter 2 to be string, array given in C:\xampplite\htdocs\zoetermeer-gezond\includes\bootstrap.inc on line 771.
    * warning: preg_match() expects parameter 2 to be string, array given in C:\xampplite\htdocs\zoetermeer-gezond\includes\bootstrap.inc on line 771.
    * warning: preg_match() expects parameter 2 to be string, array given in C:\xampplite\htdocs\zoetermeer-gezond\includes\bootstrap.inc on line 771.
    * warning: preg_match() expects parameter 2 to be string, array given in C:\xampplite\htdocs\zoetermeer-gezond\includes\bootstrap.inc on line 771.
    * warning: preg_match() expects parameter 2 to be string, array given in C:\xampplite\htdocs\zoetermeer-gezond\includes\bootstrap.inc on line 771.
    * warning: preg_match() expects parameter 2 to be string, array given in C:\xampplite\htdocs\zoetermeer-gezond\includes\bootstrap.inc on line 771.
    * warning: preg_match() expects parameter 2 to be string, array given in C:\xampplite\htdocs\zoetermeer-gezond\includes\bootstrap.inc on line 771.
    * warning: preg_match() expects parameter 2 to be string, array given in C:\xampplite\htdocs\zoetermeer-gezond\includes\bootstrap.inc on line 771.
    * warning: preg_match() expects parameter 2 to be string, array given in C:\xampplite\htdocs\zoetermeer-gezond\includes\bootstrap.inc on line 771.
    * warning: preg_match() expects parameter 2 to be string, array given in C:\xampplite\htdocs\zoetermeer-gezond\includes\bootstrap.inc on line 771.
    * warning: preg_match() expects parameter 2 to be string, array given in C:\xampplite\htdocs\zoetermeer-gezond\includes\bootstrap.inc on line 771.
    * warning: preg_match() expects parameter 2 to be string, array given in C:\xampplite\htdocs\zoetermeer-gezond\includes\bootstrap.inc on line 771.
    * warning: preg_match() expects parameter 2 to be string, array given in C:\xampplite\htdocs\zoetermeer-gezond\includes\bootstrap.inc on line 771.
    * warning: preg_match() expects parameter 2 to be string, array given in C:\xampplite\htdocs\zoetermeer-gezond\includes\bootstrap.inc on line 771.
    * warning: preg_match() expects parameter 2 to be string, array given in C:\xampplite\htdocs\zoetermeer-gezond\includes\bootstrap.inc on line 771.
    * warning: preg_match() expects parameter 2 to be string, array given in C:\xampplite\htdocs\zoetermeer-gezond\includes\bootstrap.inc on line 771.
    * warning: preg_match() expects parameter 2 to be string, array given in C:\xampplite\htdocs\zoetermeer-gezond\includes\bootstrap.inc on line 771.
    * warning: preg_match() expects parameter 2 to be string, array given in C:\xampplite\htdocs\zoetermeer-gezond\includes\bootstrap.inc on line 771.
    * warning: preg_match() expects parameter 2 to be string, array given in C:\xampplite\htdocs\zoetermeer-gezond\includes\bootstrap.inc on line 771.
    * warning: preg_match() expects parameter 2 to be string, array given in C:\xampplite\htdocs\zoetermeer-gezond\includes\bootstrap.inc on line 771.
    * warning: preg_match() expects parameter 2 to be string, array given in C:\xampplite\htdocs\zoetermeer-gezond\includes\bootstrap.inc on line 771.
    * warning: preg_match() expects parameter 2 to be string, array given in C:\xampplite\htdocs\zoetermeer-gezond\includes\bootstrap.inc on line 771.
    * warning: preg_match() expects parameter 2 to be string, array given in C:\xampplite\htdocs\zoetermeer-gezond\includes\bootstrap.inc on line 771.

I will be doing some more testing and will post my results here. If you need more information just give me a shout!

Cheers

Maybe found the reason for the mahem...
Check out the attached image.

As you can see I'm hovering over Buytenwegh which is a term of Huisarts inside the taxonomy Soort Hulpverlener.

The url it should be pointing to is something like;
category/soor-hulpverlener/huisarts/buytenwegh

But it is actually pointing to;
category/soort-hulpverlener/verloskundige/overige-hulpverleners/oefentherapeut/huisartsenpost/huisarts/fysiotherapeut/eerstelijn

Is this because of my settings?? Or might this be a bug?

Cheers

Latest comment might be related to http://drupal.org/node/376024

Thanks to everyone for testing this and Wim for the design, I wish I could help.

edit: works fine!

- admin/settings/hierarchical_select/configs
* warning: array_merge_recursive() [function.array-merge-recursive]: Argument #2 is not an array in C:\xampplite\htdocs\mydomain\sites\all\modules\hierarchical_select\hierarchical_select.admin.inc on line 79.
* warning: array_merge_recursive() [function.array-merge-recursive]: Argument #1 is not an array in C:\xampplite\htdocs\mydomain\sites\all\modules\hierarchical_select\hierarchical_select.admin.inc on line 79.
* warning: Invalid argument supplied for foreach() in C:\xampplite\htdocs\mydomain\sites\all\modules\hierarchical_select\hierarchical_select.admin.inc on line 84.

The overview of all Hierarchical Select configurations is empty

I cannot reproduce this.

Hmmz, strange, it does this on my install out of the box?

I've edited the code to see what's up

function hierarchical_select_admin_configs() {
  $header = array(t('Hierarchy type'), t('Hierarchy'), t('Entity type'), t('Entity'), t('Context type'), t('Context'), t('Actions'));

  // Retrieve all information items
  $info_items = array();
  foreach (module_implements('hierarchical_select_config_info') as $module) {
	  echo $module."\n";
	  var_dump(module_invoke($module, 'hierarchical_select_config_info'));
	  echo "\n\n";
    $info_items = array_merge_recursive($info_items, module_invoke($module, 'hierarchical_select_config_info'));
  }

This cause the following to be printed;

hs_taxonomy_views
NULL


hs_taxonomy
array(0) {
}

That NULL is causing the error I think as array_merge_recursive needs arrays for it to work...

Sorry about my other posts these bugs started when I enabled HS so my first thought was it had to with this module...

Cheers

Issue still exists in this module too.

Please Find the attached screenshot.
any solution to this?

Best,
Drupal Rocking

@Wim Leers,

I just faced this issue; which i have mentioned above. actually may be a case that i am missing something from my end. so below is the process what i have done so far and how i came across this issue.

What i have done so far;
1. using Drupal 6.15
2. using following modules:
(2.a) CCK - 6.x-2.6
(2.b) Hierarchical Select - 6.x-3.0
(2.c) Content Taxonomy - 6.x-1.0-rc2
(2.d) Views - 6.x-2.8
(2.e) Chaos tool suite(ctools) - 6.x-1.2
3. i have page as a cck
in page cck i have created one field as a - Content Taxonomy Fields
4. i have created one vocabulary - for location.
having terms like,
Vocab: Location
Terms: Location
-- USA
-- Alamba
-- City of Alamba
-- New York
-- City of New York
5. i have created one view where i want the filer as i have described in the comment #141 of this thread.

But not able to get the results; getting an error !!!! REF - comment #141 of this thread.

Please Find the attached SQL Zip File of the work i have done so far, if you are configuring this on your end; Follow Process-1 and Process-2 mentioned in this post.

This is the same issue; reason i have not started new issue :) :)
and yes .... if you want me to open new issue i can put it separate from this one :) :)

Expecting Favorable reply.

Thanks,
Drupal Rocking

@Wim Leers,

I just faced this issue; which i have mentioned above. actually may be a case that i am missing something from my end. so below is the process what i have done so far and how i came across this issue.

What i have done so far;
1. using Drupal 6.15
2. using following modules:
(2.a) CCK - 6.x-2.6
(2.b) Hierarchical Select - 6.x-3.0
(2.c) Content Taxonomy - 6.x-1.0-rc2
(2.d) Views - 6.x-2.8
(2.e) Chaos tool suite(ctools) - 6.x-1.2
3. i have page as a cck
in page cck i have created one field as a - Content Taxonomy Fields
4. i have created one vocabulary - for location.
having terms like,
Vocab: Location
Terms: Location
-- USA
-- Alamba
-- City of Alamba
-- New York
-- City of New York
5. i have created one view where i want the filer as i have described in the comment #141 of this thread.

But not able to get the results; getting an error !!!! REF - comment #141 of this thread.

Please Find the attached SQL Zip File of the work i have done so far, if you are configuring this on your end; Follow Process-1 and Process-2 mentioned in this post.

This is the same issue; reason i have not started new issue :) :)
and yes .... if you want me to open new issue i can put it separate from this one :) :)

Expecting Favorable reply.

Thanks,
Drupal Rocking