Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Problem/Motivation
We previously forked part of Doctrine's doctrine/annotations package into core at \Drupal\Component\Annotation\Doctrine.
The DocParser class depends on doctrine/lexer but this is only implicitly declared via a dependency on doctrine/annotations. However, the code is only compatible with version 2 of doctrine/lexer and upgrading to v3 results in a fatal error.
Steps to reproduce
$ composer update doctrine/lexer
$ drush cr
PHP Fatal error: Uncaught Error: Cannot use object of type Doctrine\Common\Lexer\Token as array in /var/www/html/drupal/core/lib/Drupal/Component/Annotation/Doctrine/DocParser.php:619
Proposed resolution
Add an explicit dependency on doctrine/lexer:^2.0 to both the Annotation component and core itself.
In a followup, upgrade this to doctrine/lexer:^3.0 for Drupal 11.
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
| Comment | File | Size | Author |
|---|
Issue fork drupal-3429602
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
longwaveComment #3
longwave#3267879: [meta] Add compatibility for the latest major and minor versions of dependencies to Drupal 10 seems like a reasonable parent.
Comment #5
longwaveComment #6
longwaveComment #7
needs-review-queue-bot commentedThe Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.
Comment #8
nod_testbot is having issues
Comment #9
spokjeReasoning makes sense, so do the code changes.
Comment #10
spokjeOpened follow-up #3429849: Make doctrine/lexer:^3.0 compatible with \Drupal\Component\Annotation\Doctrine.
Comment #11
alexpottCommitted 2a25e95 and pushed to 11.x. Thanks!
Drupal 10 is on v1 of annotations I don't think we need to backport there.