Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 11.

Changes will periodically be added to this issue that remove deprecated API uses. To stop further changes from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD11" tag from the issue to stop the bot from posting updates.

The changes will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated changes until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD11" tag is left on this issue, new changes will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the changes posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot changes. The bot will still post new changes then if there is a change in the new generated patch compared to the changes that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated changes.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated changes, remove the "ProjectUpdateBotD11" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated changes again, add back the "ProjectUpdateBotD11" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated changes will be posted here.

    If the issue is reopened, then new automated changes will be posted.

    If you are using another issue(s) to work on Drupal 11 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Using the merge request

  1. Review the merge request and test it.
  2. Thoroughly test the changes. These changes are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the merge request, create a new branch and merge request and work from there.

Warning: The 'project-update-bot-only' branch will always be overwritten. Do not work in that branch!

Providing feedback

If there are problems with one of the changes posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.

CommentFileSizeAuthor
#5 bibcite.3.0.x-dev.upgrade_status.post_rector.txt17.99 KBproject update bot
#5 bibcite.3.0.x-dev.rector.patch5.8 KBproject update bot
#5 interdiff-last-bot.6922093.txt1.69 KBproject update bot
#4 bibcite.3.0.x-dev.upgrade_status.post_rector.txt14.42 KBproject update bot
#4 bibcite.3.0.x-dev.rector.patch3.29 KBproject update bot
#4 interdiff-last-bot.6909776.txt1.43 KBproject update bot
#2 bibcite.3.0.0-beta3.rector.patch1.54 KBproject update bot

Issue fork bibcite-3428258

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Project Update Bot created an issue. See original summary.

project update bot’s picture

project update bot commented
Status: Active » Needs review
StatusFileSize
new bibcite.3.0.0-beta3.rector.patch1.54 KB

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module, even with these changes, this module is not yet compatible with Drupal 11.

Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.

Therefore these changes did not update the info.yml file for Drupal 11 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #11-120024

This patch was created using these packages:

  1. drupal/upgrade_status: 4.1.0
  2. mglaman/phpstan-drupal: 1.2.7
  3. palantirnet/drupal-rector: 0.20.1

Project Update Bot opened merge request !24

project update bot’s picture

project update bot commented
Version: 3.0.0-beta3 » 3.0.x-dev
StatusFileSize
new interdiff-last-bot.6909776.txt1.43 KB
new bibcite.3.0.x-dev.rector.patch3.29 KB
new bibcite.3.0.x-dev.upgrade_status.post_rector.txt14.42 KB

This comment was forced and has ignored the check if a change was already posted. This is only done when we want to update the issue without waiting for changes to happen.

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module, even with these changes, this module is not yet compatible with Drupal 11.

Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.

Therefore, these changes did not update the info.yml file for Drupal 11 compatibility.

The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

Bot run #11-137198

These packages were used to generate the fixes:

  1. drupal/upgrade_status: 4.1.0
  2. mglaman/phpstan-drupal: 1.2.10
  3. palantirnet/drupal-rector: 0.20.1
project update bot’s picture

project update bot commented
StatusFileSize
new interdiff-last-bot.6922093.txt1.69 KB
new bibcite.3.0.x-dev.rector.patch5.8 KB
new bibcite.3.0.x-dev.upgrade_status.post_rector.txt17.99 KB

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module, even with these changes, this module is not yet compatible with Drupal 11.

Currently Drupal Rector, version 0.20.3, cannot fix all Drupal 11 compatibility problems.

Therefore, these changes did not update the info.yml file for Drupal 11 compatibility.

The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

Bot run #11-199781

These packages were used to generate the fixes:

  1. drupal/upgrade_status: 4.3.2
  2. mglaman/phpstan-drupal: 1.2.11
  3. palantirnet/drupal-rector: 0.20.3
interlated’s picture

interlated commented
Issue summary: View changes

From Upgrade Status

web/modules/patched/bibcite/modules/bibcite_entity/config/optional/views.view.bibcite_contributor.yml 287 Support from all Views contextual filter settings for the default_argument_skip_url setting is removed from drupal:11.0.0. No replacement is provided. See https://www.drupal.org/node/3382316.

The change says remove it

"The Views setting default_argument_skip_url has been removed from all Views contextual filter settings. This setting has never worked and provided no clear use case that needed support in Drupal core.

mark_fullmer made their first commit to this issue’s fork.

mark_fullmer’s picture

mark_fullmer
he/him
Primary language English
Location Tucson
commented
Status: Needs review » Needs work

To better establish that this is functionally compatible with Drupal 11, I added a generic .gitlab-ci.yml template to the existing merge request. Based on the output -- see https://git.drupalcode.org/issue/bibcite-3428258/-/jobs/3511898 -- there is still a significant amount of work to do here to make this D11 compatible.

Setting to "Needs work."

mark_fullmer’s picture

mark_fullmer
he/him
Primary language English
Location Tucson
commented

I worked through a number of D11 compatibility issues and got this merge request to a point where I think the remaining problems have to do with dependencies:

1. Failing test bibcite_entity/tests/src/Kernel/EntityCitationRenderTest outputs TypeError: htmlspecialchars(): Argument #1 ($string) must be of type string, array given, which is potentially due to a problem in the dependency seboettg/citeproc-php. See https://github.com/seboettg/citeproc-php/issues/184
2. Additionally, it appears that some logic has changed in Drupal's denormalizer: bibcite_import is not importing data in the way it did in Drupal 10 at /admin/content/bibcite/reference/import, with Symfony\Component\Serializer\Exception\UnexpectedValueException: Could not determine entity type bundle: "type" field is missing. in Drupal\serialization\Normalizer\EntityNormalizer->extractBundleData() (line 115 of /core/modules/serialization/src/Normalizer/FieldableEntityNormalizerTrait.php).. This can be reproduced in the UI.

At this point, probably a maintainer needs to weigh in.

mmarler made their first commit to this issue’s fork.

mmarler’s picture

mmarler commented
Status: Needs work » Needs review

This is ready for a functional review. Still working on getting the tests to pass.

mark_fullmer’s picture

mark_fullmer
he/him
Primary language English
Location Tucson
commented
Assigned: Unassigned » mark_fullmer
mmarler’s picture

mmarler commented

Tests are now passing.

mmarler’s picture

mmarler commented

Note for the maintainers: In Drupal 11, Symfony's denormalize method was returning the wrong denormalizer provided by Bibcite. For example, when using the populate reference form to add a BibTeX reference, Symfony would return Bibcite's ContributorNormalizer class instead of the BibtexReferenceNormalizer class. After setting the BibtexReferenceNormalizer service to a higher priority, Symfony returned the correct class.

Additionally, calls to $this->serializer->denormalize in ReferenceNormalizer and BibtexReferenceNormalizer would fail to create contributor and keyword entities. Changing these to use Drupal's denormalizer seems to fix that issue.

If you approve of these changes, please consider creating a new release. Thanks!

mark_fullmer’s picture

mark_fullmer
he/him
Primary language English
Location Tucson
commented
Status: Needs review » Reviewed & tested by the community

Marking as RTBC, based on testing!

mark_fullmer’s picture

mark_fullmer
he/him
Primary language English
Location Tucson
commented
Priority: Normal » Major
mark_fullmer’s picture

mark_fullmer
he/him
Primary language English
Location Tucson
commented
Assigned: mark_fullmer » Unassigned

mark_fullmer’s picture

mark_fullmer
he/him
Primary language English
Location Tucson
commented
Status: Reviewed & tested by the community » Fixed

After another review of the changes, another confirmation that the automated tests are passing, and functional testing with an existing configured site, I confirm this should be committed, providing Drupal 11 compatibility while not changing support for previous supported versions of Drupal core.

Big thanks to @mmarler for his work on refactoring the denormalization!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.