Currently the teaser component is effectively broken. It pulls in a ton of very specific settings and options as well as uses a filter for classes that doesn't exist in Drupal. Proposing a simpler version that can be more easily built on top of.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | 3427970-1.patch | 86.52 KB | rishabjasrotia |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes, plain diff MR !116changes, plain diff MR !112
Comments
Comment #3
jnettikSubmitted MR with notes for improvements in the comments.
Comment #4
jnettikAlso potentially related to the issue in #3401403: Component: Teaser Card
Comment #5
rishabjasrotia commentedTested patch working fine.
Comment #6
rishabjasrotia commentedComment #7
pixelwhip commentedThanks for getting this started. It's definitely a step in the right direction. I've added comments to the pull request.
Comment #8
rishabjasrotia commentedHello @jnettik @pixelwhip
I have fixed some issue mentioned in the PR.
Comment #11
jldust commentedPlease review these changes.
Comment #15
pixelwhip commentedThanks everyone for your help on this. I've made some additional modifications and merged it into 5.x. There are some related changes I'd like to consider regarding the links and spacing but will handle that elsewhere. For now, this is a big improvement over the previous teaser and provides a more sane default.
Comment #16
jldust commented