Motivation

The ability for the admin to hide the view header

Steps to reproduce

n/a

Proposed resolution

Add an option that allows removing the header.

Remaining tasks

n/a

User interface changes

n/a

API changes

n/a

Data model changes

n/a

CommentFileSizeAuthor
#2 3427005-2.patch1.27 KBalshami
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

alshami created an issue. See original summary.

alshami’s picture

StatusFileSize
new1.27 KB

This patch add extra setting to hide the header of the view

alshami’s picture

Assigned: alshami » Unassigned
Issue summary: View changes
Status: Active » Needs review
scott_euser’s picture

Status: Needs review » Needs work

Thanks for the work on this! A few things:

  1. Can this be converted to a merge request to make it easier to review and comment please? + so tests run
  2. This needs test coverage, which can be added to ViewsReferenceSettingsTest.php

manish-31 made their first commit to this issue’s fork.

manish-31’s picture

Status: Needs work » Needs review

Patch #2 did not work for me, in my case there was no value in $view->display_handler->options['header']. I believe $view->display_handler->getOption('header') would be a good choice and safe option.

Opened MR that includes test coverage for hide header option and the above change. Needs review. Thanks!

scott_euser’s picture

Status: Needs review » Fixed

Great stuff, thank you! Did a round of manual testing as well and all working as expected. Thank you for adding the test coverage as well.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

trackleft2’s picture

Issue summary: View changes
trackleft2’s picture

Issue summary: View changes