Drupal 11 might be released as soon as 3½ months from now, so it’s high time to make sure this module is ready.

CommentFileSizeAuthor
#3 3425236-3.patch5.77 KBsamitk

Issue fork search_api_autocomplete-3425236

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

drunken monkey created an issue. See original summary.

samitk’s picture

samitk commented
Assigned: Unassigned » samitk
Status: Active » Needs work
samitk’s picture

samitk commented
Assigned: samitk » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 3425236-3.patch5.77 KB

Hi @drunken monkey,

Please review the patch.

Thanks
Samit K.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented

Thanks for the patch!
However, is there a reason you removed src/AutocompleteBackendInterface.php? This seems quite unrelated to Drupal 11 support.

Created an MR that just declares support, should be all that’s needed. Unfortunately, we cannot properly test this until Search API and Search API Pages declare Drupal 11 support, too.

drunken monkey opened merge request !18

samitk’s picture

samitk commented

Hi @drunken monkey,

As search_api also have the same AutocompleteBackendInterface interface.

modules/contrib/search_api/src/Contrib/AutocompleteBackendInterface.php

Thanks
Samit K.

  • drunken monkey committed dfdb0b2b on 8.x-1.x 
    Issue #3425236 by drunken monkey, samit.310@gmail.com: Fixed...
drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Needs review » Fixed

Merged. Thanks again!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Closed (fixed) » Postponed
Related issues: +#3427144: Make module compatible with Drupal 11

Keeping this open so I remember to turn on testing against Drupal 11 once it’s available. However, still waiting on Search API Pages (#3427144: Make module compatible with Drupal 11) for that.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Title: Make module compatible with Drupal 11 » Make Search API Autocomplete module compatible with Drupal 11
Related issues: +#3425235: Make the Search API module compatible with Drupal 11

Turns out the Search API module itself is not ready (currently just throws fatal errors, see #3425235-12: Make the Search API module compatible with Drupal 11), so still need to wait for that, too.
I did, however, just commit the Search API Pages patch, so that’s something.

ankitv18 made their first commit to this issue’s fork.

ankitv18 opened merge request !25

ankitv18’s picture

ankitv18 commented
Assigned: Unassigned » ankitv18
Status: Postponed » Needs work

As search_api is released with D10.1 and D11 support, Rechecking if any work is left on this.

ankitv18 changed the visibility of the branch 3425236-search-api-ready-d11 to hidden.

ankitv18 opened merge request !26

ankitv18 changed the visibility of the branch 3425236-drupal-11-compatibility to hidden.

ankitv18’s picture

ankitv18 commented
Assigned: ankitv18 » Unassigned
Status: Needs work » Needs review

drunken monkey closed merge request !25

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Needs review » Fixed

Looks great, thanks! Just fixed the remaining fail in SearchCrudTest and then merged.
Thanks again!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.