Problem/Motivation

Besides the normal flow, Sendinblue/Brevo supports double opt-in.
There should be an option in the Webform handler for activating it, similar to how the Webform Mailchimp handler does it.

Issue fork sendinblue_api-3424946

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mrshowerman created an issue. See original summary.

mrshowerman’s picture

mrshowerman
Location Munich
commented
Related issues: +#3357212: Webform Handler does not work

Note that the webform handler only works after applying the patch from #3357212: Webform Handler does not work first.

mrshowerman opened merge request !2

mrshowerman’s picture

mrshowerman
Location Munich
commented
Assigned: mrshowerman » Unassigned
Status: Active » Needs review

To avoid merge conflicts when including both this patch and the one from #3357212: Webform Handler does not work, I also included the fix from there.

sujan shrestha’s picture

sujan shrestha commented

Thanks @mrshowerman, I'll review it.

mrshowerman’s picture

mrshowerman
Location Munich
commented
Version: 1.1.4 » 1.2.0

Rebased on 1.2.0.

schoenef’s picture

schoenef commented

Hello, are there any news on this one? We would like to have this feature as well.

Thx a lot everybody!

schoenef’s picture

schoenef commented

Hi @mrshowman, is there a way I can tryout your fork? We need this feature for a client as well,

Thx a lot!
Andreas

mrshowerman’s picture

mrshowerman
Location Munich
commented

Sure, you can apply the MR as a composer patch.
Download the MR's patch file to your local project using the "plain diff" above and follow the instructions in https://www.drupal.org/docs/develop/using-composer/manage-dependencies#p...

schoenef’s picture

schoenef commented

Thank you! I did not see the plain diff link.

It applies very well by adding

"patches": {
            "drupal/sendinblue_api": {
                "#3424946_doi": "https://git.drupalcode.org/project/sendinblue_api/-/merge_requests/2.diff"
            }
        },

to the composer.json file.

mrshowerman’s picture

mrshowerman
Location Munich
commented

Glad it works!

But you should never use a direct URL to an MR's diff file, because that could change with future updates, and you never know if you really want those changes in your project.
Instead, download the file to your project and reference it locally:

"patches": {
    "drupal/sendinblue_api": {
        "#3424946_doi": "patches/sendinblue_api/3424946.diff"
    }
},
schoenef’s picture

schoenef commented
Status: Needs review » Reviewed & tested by the community

So from the functional point of view, this works very well - I have just installed and tested it.

Codewise it is also fine from my point of view.

mrshowerman’s picture

mrshowerman
Location Munich
commented

Thanks for merging this, @finex!
But shouldn't this issue be fixed then?

finex’s picture

finex commented
Status: Reviewed & tested by the community » Fixed
mrshowerman’s picture

mrshowerman
Location Munich
commented
Status: Fixed » Reviewed & tested by the community

Wow. No credit at all?

mrshowerman’s picture

mrshowerman
Location Munich
commented
Status: Reviewed & tested by the community » Fixed
finex’s picture

finex commented

I'm very sorry, I thought it was automatic. I've just edited the release description message!

mrshowerman’s picture

mrshowerman
Location Munich
commented

You have to tick the checkboxes below "Credit & committing" if you want to give credit 😉

finex’s picture

finex commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.