By adt55 on

After upgrading to 10.2.3 the visually hidden option under manage display no longer is hiding the labels. The field labels are set to visually hidden but still show the labels above images and different structures. They only disappear once they are set to "hidden". 

⋅ Categories: Drupal 10.x

Comments

vm’s picture

vm commented

what theme is in use? if not a core theme, have you tested on a core theme?

adt55’s picture

adt55 commented

We haven't tested it with a core theme, we just have a custom theme in use.

vm’s picture

vm commented

suggest puling a copy of the site and testing. This will aid in understanding if it's a theme issue or a code base issue.

adt55’s picture

adt55 commented

Used a core theme to see if it as the same issue, but now some of the labels work and will appear "visually hidden" and other labels that were working before no longer work. They will only stay hidden when switched to "hidden". Not sure where to go from that.

jayemel’s picture

jayemel commented

We are seeing this too. After upgrading from 9.5.11 to 10.2.5, first thing we noticed was many images using "URL to image" display mode with "visually hidden" label, had broken URLs. Inspecting the URLs, we saw that the field label (and entity name!?) was being added to the URL, where previously it wasn't.

so previoulsy the url would have correctly output /sites/default/files/filename.jpg now it was output as /our_custom_entity_name/Image/sites/default/files/filename.jpg

We needed to switch the label to "hidden" to get it to actually hide and output the correct "URL to image".

So it seems visually hidden is behaving differently than before, at least when used in a media display mode with "url to image" format.

rikazkhan’s picture

rikazkhan commented

what theme you currently using?

jayemel’s picture

jayemel commented

A custom theme. It's not doing anything special...just  a normal image field attached to an entity, displayed as "URL to image", with a custom media view mode that is set to display "URL to image". 

I think the greater point is that something has changed that makes "visually hidden" labels appear when using "URL to image". One could argue that it should be set to hidden.. and we probably just set it "visually hidden" before and left it like that because it worked. 

But one could also argue that using "URL to image" should always ignore the label settings, because it's not the "URL to image" anymore if it has label data packed in there. That's how it used to work, so something changed, whether this is a regression or not is up for debate I guess.