Problem/Motivation

After upgrading to 2.10-beta5 version we see 3 warnings:
Warning: Undefined array key "name" in pwa_extras_page_attachments() (line 55 of modules/contrib/pwa/modules/pwa_extras/pwa_extras.module).

CommentFileSizeAuthor
#3 pwa-3422906-3.patch889 bytesalina.basarabeanu
#2 3422906-2.patch676 bytesdineshkumarbollu
pwa-WARNINGS.png285.21 KBalina.basarabeanu

Issue fork pwa-3422906

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Alina Basarabeanu created an issue. See original summary.

dineshkumarbollu’s picture

dineshkumarbollu commented
Status: Active » Needs review
StatusFileSize
new 3422906-2.patch676 bytes
alina.basarabeanu’s picture

alina.basarabeanu commented
StatusFileSize
new pwa-3422906-3.patch889 bytes

A new patch was added.

proweb.ua’s picture

proweb.ua commented

#3 works

kris77’s picture

kris77 commented

#3 works for me too.

Thanks @Alina Basarabeanu

rishabjasrotia made their first commit to this issue’s fork.

rishabjasrotia opened merge request !98

silvi.addweb’s picture

silvi.addweb commented
Status: Needs review » Reviewed & tested by the community

I have tested patch #3 and it worked as expected. It would be great to have it merged. Marking it as RTBC.

bgustafson’s picture

bgustafson commented

I can't say I looked to understand the implication of the tag attribute name not being set, but #3 works for me to get rid of the warnings.

sphism’s picture

sphism commented

#3 got rid of the warnings for me

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Reviewed & tested by the community » Needs work
Related issues: +#3478671: pwa_extras regression after #3395058

It gets rid of the errors, but does not solve the problem. See the alternative solution in #3478671: pwa_extras regression after #3395058

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs work » Closed (duplicate)

Closing this as duplicate of #3478671: pwa_extras regression after #3395058 as suggested by @heddn. Fixed over there. Thank you!