Problem/Motivation

Warning: Undefined array key "name" in pwa_extras_page_attachments() (line 55 of modules/contrib/pwa/modules/pwa_extras/pwa_extras.module).

Warning: Undefined array key "name" in pwa_extras_page_attachments() (line 55 of modules/contrib/pwa/modules/pwa_extras/pwa_ext

Steps to reproduce

Install and configure the pwa_extras.
Because all of the metatags in pwa_extras_tag_list pass through Html::escape, when it gets passed through (new DOMDocument())->loadHTML() the values are escaped and the above error happens.

Proposed resolution

In place of Html::escape use Xss::filter

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork pwa-3478671

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jeremy1606 created an issue. See original summary.

jeremy1606 opened merge request !101

jerech’s picture

jerech commented
Status: Active » Needs review
joshahubbers’s picture

joshahubbers commented

I think this is a duplicate of #3422906: Undefined array key "name", which is done...

joshahubbers’s picture

joshahubbers commented
Related issues: +#3422906: Undefined array key "name"
joshahubbers’s picture

joshahubbers commented
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Reviewed & tested by the community

Thanks for the fix!

  • anybody committed e89c5b48 on 2.x authored by jeremy1606 
    Issue #3478671 by jeremy1606: pwa_extras regression after #3395058
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.