Hi,

I am using the Windows system and the Drupal version is 10.2.3. I am working on Single Directory Components. When I add styles/js to the components, those are not added properly. The path was wrong, because of the "DIRECTORY_SEPARATOR" constant variable in the code. Windows considered this "\" but should be "/". So, I checked the code and created a patch to fix it. This will work on all OS. Please, check the patch file below.

Thanks,
Saranya.

CommentFileSizeAuthor
#9 3422606-nr-bot.txt991 bytesneeds-review-queue-bot
#2 sdc-li-path-3422606-2.patch874 bytessaranya ashokkumar

Issue fork drupal-3422606

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

saranya ashokkumar created an issue. See original summary.

saranya ashokkumar’s picture

saranya ashokkumar commented
Title: Issue with SDC » Issue with loading libraries in SDC
StatusFileSize
new sdc-li-path-3422606-2.patch874 bytes
saranya ashokkumar’s picture

saranya ashokkumar commented
saranya ashokkumar’s picture

saranya ashokkumar commented
Status: Active » Needs review
needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Needs review » Needs work

The Needs Review Queue Bot tested this issue.

While you are making the above changes, we recommend that you convert this patch to a merge request. Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)

Mithun S made their first commit to this issue’s fork.

Mithun S opened merge request !6741

mithun s’s picture

mithun s
Primary language English
Location Bangalore
commented
Status: Needs work » Needs review

Created a MR for the issue with the changes of above patch. Any further changes can be pushed to the same branch.
Thank you!

needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Needs review » Needs work
StatusFileSize
new 3422606-nr-bot.txt991 bytes

The Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

xjm’s picture

xjm
she/her
Primary language English
commented
Version: 10.2.x-dev » 11.x-dev

Note that all merge requests should be created against 11.x. It's often simplest to create a new MR against 11.x and close the old ones. Thanks!

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.