Problem/Motivation

When adding a video via the media embed button of a topic, after having clicked on the ok, the video is well embedded, but the whole topic is frozen and it is impossible to save and publish the topic anymore.

Steps to reproduce

  1. Enable social_embed
  2. Go to node/add/topic
  3. Fill the title
  4. In description field click on “Url Embed“ icon
  5. In the modal window add URL Welcome to Open Social - Online Community Engagement Platform - Demo Video
  6. Click “Embed“ button - the window doesn’t close after submit
  7. Close the window
  8. Try to scroll the page - you can’t do it

Proposed resolution

Add a patch #2 from https://www.drupal.org/project/drupal/issues/3409505

Comments

Luckie Joe created an issue. See original summary.

ribel’s picture

ribel
Primary language Ukrainian
Location 🇺🇦Lviv
commented
Status: Active » Needs review

PR with a patch was tested and works as expected:
https://github.com/goalgorilla/open_social/pull/3784

ribel’s picture

ribel
Primary language Ukrainian
Location 🇺🇦Lviv
commented
Status: Needs review » Reviewed & tested by the community

PR was merged and should be released in the next versions 12.1.3 and 12.2.0

ribel’s picture

ribel
Primary language Ukrainian
Location 🇺🇦Lviv
commented
Priority: Critical » Major

  • ribel committed db8790df on 12.1.x 
    Issue #3422423: Add check on reading null in toolbar.js (patch for...

  • e4b3bf1f committed on 12.2.x 
    Issue #3422423: Add check on reading null in toolbar.js (patch for...

  • ribel committed bc49e4a6 on 12.2.x 
    Issue #3422423: Add check on reading null in toolbar.js (patch for...
ronaldtebrake’s picture

ronaldtebrake commented
Status: Reviewed & tested by the community » Fixed

Released as part of 12.2.0

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.