Problem/Motivation

When re-ordering images the new weights are not saved

Steps to reproduce

  1. Edit an entity
  2. re-order images
  3. observe the order is not saved
CommentFileSizeAuthor
#12 sort2Result.png422.37 KBdivya.sejekan
#12 sort2.png138.36 KBdivya.sejekan
#12 sort1Result.png410.68 KBdivya.sejekan
#12 sort1.png138.43 KBdivya.sejekan
#11 fiu-re-order-5.patch2.07 KBgfarishyan
#9 3422202-4.patch3.53 KBrishabjasrotia
#7 3422202-3.patch1.55 KBrishabjasrotia
#2 fiu-invisible-weights-3422202-2.patch372 bytesakhoury

Issue fork fiu-3422202

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

akhoury created an issue. See original summary.

akhoury’s picture

akhoury
Location Dubai
commented
StatusFileSize
new fiu-invisible-weights-3422202-2.patch372 bytes
shevgeny’s picture

shevgeny
Primary language English
commented

The module without the patch doesn't sort images at all, with the patch - it sometimes sorts, sometimes doesn't.

liukevich’s picture

liukevich commented

Hello! I solved the problem this way. (Drupal 10.2.3)

Edit file: "modules/fiu/templates/fine-image-widget.html.twig"
After (~38 lines): 

{% if data.title %}
   {{ data.title }}
{% endif %}

Add:

{% if data._weight %}{{ data._weight }}{% endif %}

rishabjasrotia made their first commit to this issue’s fork.

rishabjasrotia opened merge request !7

rishabjasrotia’s picture

rishabjasrotia commented
StatusFileSize
new 3422202-3.patch1.55 KB
divya.sejekan’s picture

divya.sejekan commented
Status: Needs review » Needs work

Tried with both MR's , The changes are not reflected . Still the sort is not working

rishabjasrotia’s picture

rishabjasrotia commented
StatusFileSize
new 3422202-4.patch3.53 KB

Hello @divya.sejekan please use the latest patch added I have tested it in plain drupal setup.
It is working as needed.

rishabjasrotia’s picture

rishabjasrotia commented
Assigned: akhoury » Unassigned
Status: Needs work » Needs review
gfarishyan’s picture

gfarishyan commented
StatusFileSize
new fiu-re-order-5.patch2.07 KB

I'm attaching file which will fix issue not only when _weight is a select but also when it's input.
Also _weight field should be excluded in fine-image-widget.html as drupal data already renders it.

divya.sejekan’s picture

divya.sejekan commented
StatusFileSize
new sort1.png138.43 KB
new sort1Result.png410.68 KB
new sort2.png138.36 KB
new sort2Result.png422.37 KB

Patch in #11 seems to work -> fiu-re-order-5.patch . The order of the image is changeable and sorting works , and is displayed the same in view page
RTBC++