Problem/Motivation

In #3252386: Use PHP attributes instead of doctrine annotations we added support for attribute based plugin discovery.
As part of that issue we converted block and action plugins.

This issue is to convert \Drupal\migrate_drupal\Annotation\MigrateFieldplugins to use Attributes.

Proposed resolution

Convert the remaining MigrateField plugins

Remaining tasks

#3424509: Update MigratePluginManager to include both attribute and annotation class
Review
Commit

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3421020

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

larowlan created an issue. See original summary.

mohit_aghera made their first commit to this issue’s fork.

mohit_aghera’s picture

mohit_aghera commented
Assigned: Unassigned » mohit_aghera

mohit_aghera opened merge request !6781

mohit_aghera’s picture

mohit_aghera commented
Status: Active » Needs work

Note: BC approach to handle annotations and attributes in MigratePluginManager class is being evaluated in https://www.drupal.org/project/drupal/issues/3424509

We should revisit and rebase this PR after this is resolved.

godotislate’s picture

godotislate
he/him
commented
Status: Needs work » Postponed

Blocked on #3424509: Update MigratePluginManager to include both attribute and annotation class

catch’s picture

catch
he/him
Primary language English
commented
Status: Postponed » Needs work

quietone made their first commit to this issue’s fork.

quietone’s picture

quietone commented
Issue summary: View changes
Status: Needs work » Needs review
quietone’s picture

quietone commented
Issue summary: View changes
Status: Needs review » Postponed
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Postponed » Closed (duplicate)
godotislate’s picture

godotislate
he/him
commented
Status: Closed (duplicate) » Needs work

Re-opened to convert remaining migrate field plugins. Added some comments on the MR.

godotislate’s picture

godotislate
he/him
commented
Status: Needs work » Needs review

My suggestions were minor and straightforward, so I went ahead and applied them to get into review.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs Review Queue Initiative

This seems like another pure conversion.

Searched repo for @MigrateField and all instances have been replaced.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Version: 11.x-dev » 10.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed 8e51b463d5 to 11.x and 55e5ee436c to 10.3.x. Thanks!

  • alexpott committed 55e5ee43 on 10.3.x 
    Issue #3421020 by godotislate, mohit_aghera, quietone: Convert...

  • alexpott committed 8e51b463 on 11.x 
    Issue #3421020 by godotislate, mohit_aghera, quietone: Convert...

quietone closed merge request !6781

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.