Problem/Motivation

In #3252386: Use PHP attributes instead of doctrine annotations we added support for attribute based plugin discovery.
As part of that issue we converted block and action plugins.

This issue is to convert \Drupal\language\Annotation\LanguageNegotiationplugins to use Attributes.

Proposed resolution

  1. Add a class to represent the new Attribute - Example
  2. Update the plugin manager constructor to include both the attribute and annotation class names - example
  3. Convert all plugins that use the annotation to use the new attribute - example

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3421017

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

larowlan created an issue. See original summary.

mohit_aghera made their first commit to this issue’s fork.

mohit_aghera’s picture

Assigned: Unassigned » mohit_aghera

mohit_aghera’s picture

Status: Active » Needs review
smustgrave’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs Review Queue Initiative

Searched for @LanguageNegotiation and all 11 instances have been replaced.

Attribute appears correct based on how we've done the others.

alexpott’s picture

Version: 11.x-dev » 10.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed 2001751fd9 to 11.x and 41437f5b94 to 10.3.x. Thanks!

  • alexpott committed 41437f5b on 10.3.x
    Issue #3421017 by mohit_aghera, smustgrave: Convert LanguageNegotiation...

  • alexpott committed 2001751f on 11.x
    Issue #3421017 by mohit_aghera, smustgrave: Convert LanguageNegotiation...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.