Problem/Motivation

In #3252386: Use PHP attributes instead of doctrine annotations we added support for attribute based plugin discovery.
As part of that issue we converted block and action plugins.

This issue is to convert \Drupal\search\Annotation\SearchPluginplugins to use Attributes.

Proposed resolution

  1. Add a class to represent the new Attribute - Example
  2. Update the plugin manager constructor to include both the attribute and annotation class names - example
  3. Convert all plugins that use the annotation to use the new attribute - example

Remaining tasks

Needs review

User interface changes

N/A

API changes

N/A

Data model changes

N/A

Release notes snippet

Issue fork drupal-3421013

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

larowlan created an issue. See original summary.

mohit_aghera made their first commit to this issue’s fork.

mohit_aghera’s picture

mohit_aghera commented
Assigned: Unassigned » mohit_aghera

mohit_aghera opened merge request !6721

mohit_aghera’s picture

mohit_aghera commented
Assigned: mohit_aghera » Unassigned
Issue summary: View changes
Status: Active » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs Review Queue Initiative

Feedback appears to be addressed around the annotation

Searched for @SearchPlugin and all 4 instances have been updated.

mstrelan’s picture

mstrelan commented
Status: Reviewed & tested by the community » Needs work

A couple comments that need updating and wondering if we should rename the attribute while we're converting it?

mohit_aghera’s picture

mohit_aghera commented
Status: Needs work » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Feedback from @mstrelan appears to be addressed.

mstrelan’s picture

mstrelan commented
Status: Reviewed & tested by the community » Needs work
quietone’s picture

quietone commented
Status: Needs work » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Seems additional comments have been corrected.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs work

This is missing the deriver property per #3421793: Add an assert that ensures all attribute plugins support derivers

sorlov made their first commit to this issue’s fork.

sorlov’s picture

sorlov commented
Status: Needs work » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Deriver has been added

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Version: 11.x-dev » 10.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed 1e1dc945bb to 11.x and ee98c76bf5 to 10.3.x. Thanks!

  • alexpott committed ee98c76b on 10.3.x 
    Issue #3421013 by mohit_aghera, sorlov, smustgrave, mstrelan, larowlan,...

  • alexpott committed 1e1dc945 on 11.x 
    Issue #3421013 by mohit_aghera, sorlov, smustgrave, mstrelan, larowlan,...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.