Problem/Motivation

In #3252386: Use PHP attributes instead of doctrine annotations we added support for attribute based plugin discovery.
As part of that issue we converted block and action plugins.

This issue is to convert \Drupal\views\Annotation\ViewsAccessplugins to use Attributes.

There is no need to wait for the base class \Drupal\views\Annotation\ViewsPluginAnnotationBase as this plugin does not use that feature. It should instead extend from the base Plugin attribute in core.

Proposed resolution

  1. Add a class to represent the new Attribute - Example
  2. Update the plugin manager constructor to include both the attribute and annotation class names - example
  3. Convert all plugins that use the annotation to use the new attribute - example

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3421001

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

larowlan created an issue. See original summary.

larowlan’s picture

Title: [PP-1] Convert ViewsAccess plugin discovery to attributes » Convert ViewsAccess plugin discovery to attributes
Issue summary: View changes
Status: Postponed » Active
Related issues: -#3421006: Convert ViewsDisplayExtender plugin discovery to attributes
mohit_aghera’s picture

Assigned: Unassigned » mohit_aghera

sorlov made their first commit to this issue’s fork.

sorlov’s picture

Status: Active » Needs review
smustgrave’s picture

Assigned: mohit_aghera » Unassigned
Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs Review Queue Initiative

All 5 instances of @ViewsAccess appear to be replaced.

alexpott’s picture

Status: Reviewed & tested by the community » Needs work

Added some typehinting suggestions.

sorlov’s picture

Status: Needs work » Needs review
mohit_aghera’s picture

Status: Needs review » Reviewed & tested by the community

I noticed that both the changes has been addressed.
Moving back to RTBC since tests are green as well.

alexpott’s picture

Status: Reviewed & tested by the community » Needs work

Added some comments to the MR.

sorlov’s picture

Status: Needs work » Needs review
smustgrave’s picture

Status: Needs review » Reviewed & tested by the community

Suggestions appear to be addressed.

alexpott’s picture

Version: 11.x-dev » 10.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed 287239234a to 11.x and 364518db9e to 10.3.x. Thanks!

  • alexpott committed 364518db on 10.3.x
    Issue #3421001 by sorlov, mohit_aghera, larowlan, alexpott, smustgrave:...

  • alexpott committed 28723923 on 11.x
    Issue #3421001 by sorlov, mohit_aghera, larowlan, alexpott, smustgrave:...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.