Problem/Motivation

In #3252386: Use PHP attributes instead of doctrine annotations we added support for attribute based plugin discovery.
As part of that issue we converted block and action plugins.

This issue is to convert \Drupal\image\Annotation\ImageEffectplugins to use Attributes.

Proposed resolution

  1. Add a class to represent the new Attribute - Example
  2. Update the plugin manager constructor to include both the attribute and annotation class names - example
  3. Convert all plugins that use the annotation to use the new attribute - example

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3420996

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

larowlan created an issue. See original summary.

mstrelan made their first commit to this issue’s fork.

mstrelan opened merge request !6624

mstrelan’s picture

mstrelan commented
Status: Active » Needs review
kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
commented
Status: Needs review » Reviewed & tested by the community

All docs are copied over. Searched the codebase and found no usages of the old annotation. All looks good to me.

mstrelan’s picture

mstrelan commented
Status: Reviewed & tested by the community » Needs work

As per @larowlan I think we need to add public readonly ?string $deriver = NULL to the constructor params.

mstrelan’s picture

mstrelan commented
Status: Needs work » Needs review
kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
commented
Status: Needs review » Reviewed & tested by the community

$deriver has been added to back to RTBC

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Version: 11.x-dev » 10.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed 58ecf6d433 to 11.x and 6d67339df5 to 10.3.x. Thanks!

Adding to the CR https://www.drupal.org/node/3395575

  • alexpott committed 6d67339d on 10.3.x 
    Issue #3420996 by mstrelan, kim.pepper, larowlan: Convert ImageEffect...

  • alexpott committed 58ecf6d4 on 11.x 
    Issue #3420996 by mstrelan, kim.pepper, larowlan: Convert ImageEffect...

mstrelan closed merge request !6624

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.