Problem/Motivation

In #3252386: Use PHP attributes instead of doctrine annotations we added support for attribute based plugin discovery.
As part of that issue we converted block and action plugins.

This issue is to convert \Drupal\rest\Annotation\RestResourceplugins to use Attributes.

Proposed resolution

  1. Add a class to represent the new Attribute - Example
  2. Update the plugin manager constructor to include both the attribute and annotation class names - example
  3. Convert all plugins that use the annotation to use the new attribute - example

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3420994

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

larowlan created an issue. See original summary.

kim.pepper made their first commit to this issue’s fork.

kim.pepper’s picture

Status: Active » Needs review

Created an MR

smustgrave’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs Review Queue Initiative

Using Block attribute as a reference this appears to be done similarly.

Searched for @RestResource and all 5 instances in core have been updated.

LGTM

alexpott’s picture

Version: 11.x-dev » 10.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed d17c830288 to 11.x and 67c22284ec to 10.3.x. Thanks!

  • alexpott committed 67c22284 on 10.3.x
    Issue #3420994 by kim.pepper: Convert RestResource plugin discovery to...

  • alexpott committed d17c8302 on 11.x
    Issue #3420994 by kim.pepper: Convert RestResource plugin discovery to...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.