Problem/Motivation

In #3252386: Use PHP attributes instead of doctrine annotations we added support for attribute based plugin discovery.
As part of that issue we converted block and action plugins.

This issue is to convert \Drupal\Core\Annotation\QueueWorkerplugins to use Attributes.

Proposed resolution

  1. Add a class to represent the new Attribute - Example
  2. Update the plugin manager constructor to include both the attribute and annotation class names - example
  3. Convert all plugins that use the annotation to use the new attribute - example

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3420988

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

larowlan created an issue. See original summary.

godotislate made their first commit to this issue’s fork.

godotislate opened merge request !6765

godotislate’s picture

godotislate
he/him
commented
Status: Active » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work
Issue tags: +Needs Review Queue Initiative

Left a small change. There was discussion on another Convert ticket (sorry can't find the exact one) about the @Annotation and believe it's being removed.

But all instances of @QueueWorker have been replaced. @godotislate probably good to self RTBC after that small tweak.

Thanks.

godotislate’s picture

godotislate
he/him
commented
Status: Needs work » Reviewed & tested by the community

Removed @Annotation . RTBC per #5.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 636182e and pushed to 11.x. Thanks!
Committed fdd6ca5 and pushed to 10.3.x. Thanks!

  • alexpott committed fdd6ca5b on 10.3.x 
    Issue #3420988 by godotislate, smustgrave: Convert QueueWorker plugin...

  • alexpott committed 636182e6 on 11.x 
    Issue #3420988 by godotislate, smustgrave: Convert QueueWorker plugin...

godotislate closed merge request !6765

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.