Problem/Motivation

In #3252386: Use PHP attributes instead of doctrine annotations we added support for attribute based plugin discovery.
As part of that issue we converted block and action plugins.

This issue is to convert \Drupal\Core\TypedData\Annotation\DataTypeplugins to use Attributes.

Proposed resolution

  1. Add a class to represent the new Attribute - Example
  2. Update the plugin manager constructor to include both the attribute and annotation class names - example
  3. Convert all plugins that use the annotation to use the new attribute - example

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3420987

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

larowlan created an issue. See original summary.

kim.pepper made their first commit to this issue’s fork.

kim.pepper’s picture

Status: Active » Needs review
kim.pepper’s picture

smustgrave’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs Review Queue Initiative

Based on how others were done this appears corrected

Searched the repo for @DataType and 24 instances were replaced here.

  • alexpott committed 17b3cf71 on 10.3.x
    Issue #3420987 by kim.pepper, smustgrave: Convert DataType plugin...

  • alexpott committed e32a8fd3 on 11.x
    Issue #3420987 by kim.pepper, smustgrave: Convert DataType plugin...
alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed e32a8fd37c to 11.x and 17b3cf71b3 to 10.3.x. Thanks!

kim.pepper’s picture

Closed MR

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.