Problem/Motivation

In #3252386: Use PHP attributes instead of doctrine annotations we added support for attribute based plugin discovery.
As part of that issue we converted block and action plugins.

This issue is to convert \Drupal\Core\Archiver\Annotation\Archiverplugins to use Attributes.

Proposed resolution

  1. Add a class to represent the new Attribute - Example
  2. Update the plugin manager constructor to include both the attribute and annotation class names - example
  3. Convert all plugins that use the annotation to use the new attribute - example

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3420985

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

larowlan created an issue. See original summary.

godotislate made their first commit to this issue’s fork.

godotislate opened merge request !6819

godotislate’s picture

godotislate
he/him
commented
Status: Active » Needs review

Put up MR.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs Review Queue Initiative

Reviewed the change based on how others have been done and seems inline

Searched @Archiver and all 3 instances have been replaced.

mstrelan’s picture

mstrelan commented
Status: Reviewed & tested by the community » Needs work

Couple places to update docs.

godotislate’s picture

godotislate
he/him
commented
Status: Needs work » Needs review

Updated comments per review.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Feedback appears to be addressed

  • catch committed 9b7b5a9d on 10.3.x 
    Issue #3420985 by godotislate, larowlan, smustgrave, mstrelan: Convert...

  • catch committed 4ae7f854 on 11.x 
    Issue #3420985 by godotislate, larowlan, smustgrave, mstrelan: Convert...
catch’s picture

catch
he/him
Primary language English
commented
Version: 11.x-dev » 10.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x and cherry-picked to 10.3.x, thanks!

catch closed merge request !6819

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.