Problem/Motivation

In #3252386: Use PHP attributes instead of doctrine annotations we added support for attribute based plugin discovery.
As part of that issue we converted block and action plugins.

This issue is to convert \Drupal\Core\Field\Annotation\FieldFormatter plugins to use Attributes.

Proposed resolution

  1. Add a class to represent the new Attribute - Example
  2. Update the plugin manager constructor to include both the attribute and annotation class names - example
  3. Convert all plugins that use the annotation to use the new attribute - example

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3420980

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

larowlan created an issue. See original summary.

mstrelan made their first commit to this issue’s fork.

mstrelan opened merge request !6777

mstrelan’s picture

mstrelan commented
Status: Active » Needs work

Still a bunch of formatters to convert, and failing tests to fix.

mstrelan’s picture

mstrelan commented
Status: Needs work » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs Review Queue Initiative

Based on others this seems inline with those.

Searched for @FieldFormatter and all 65 instances have been replaced.

LGTM!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Version: 11.x-dev » 10.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed dcecab3d42 to 11.x and cd8d76a2df to 10.3.x. Thanks!

  • alexpott committed cd8d76a2 on 10.3.x 
    Issue #3420980 by mstrelan, smustgrave: Convert FieldFormatter plugin...

  • alexpott committed dcecab3d on 11.x 
    Issue #3420980 by mstrelan, smustgrave: Convert FieldFormatter plugin...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.